diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2022-09-23 09:10:16 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2022-09-23 09:10:16 +0200 |
| commit | 2ec6489d7a595c78cae4584244afd4ca91d6c8ff (patch) | |
| tree | c33aaffb1043c4b6e42f1f31aa54b720b89a1082 /gcc | |
| parent | a282f086ef26d90e9785e992cd09a0d118b24695 (diff) | |
| download | gcc-2ec6489d7a595c78cae4584244afd4ca91d6c8ff.zip gcc-2ec6489d7a595c78cae4584244afd4ca91d6c8ff.tar.gz gcc-2ec6489d7a595c78cae4584244afd4ca91d6c8ff.tar.bz2 | |
attribs: Improve diagnostics
When looking at the attribs code, I've noticed weird diagnostics
like
int a __attribute__((section ("foo", "bar")));
a.c:1:1: error: wrong number of arguments specified for ‘section’ attribute
1 | int a __attribute__((section ("foo", "bar")));
| ^~~
a.c:1:1: note: expected between 1 and 1, found 2
As roughly 50% of attributes that accept any arguments have
spec->min_length == spec->max_length, I think it is worth it to have
separate wording for such common case and just write simpler
a.c:1:1: note: expected 1, found 2
2022-09-23 Jakub Jelinek <jakub@redhat.com>
* attribs.cc (decl_attributes): Improve diagnostics, instead of
saying expected between 1 and 1, found 2 just say expected 1, found 2.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/attribs.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gcc/attribs.cc b/gcc/attribs.cc index fb89616..b1f1032 100644 --- a/gcc/attribs.cc +++ b/gcc/attribs.cc @@ -737,6 +737,9 @@ decl_attributes (tree *node, tree attributes, int flags, if (spec->max_length < 0) inform (input_location, "expected %i or more, found %i", spec->min_length, nargs); + else if (spec->min_length == spec->max_length) + inform (input_location, "expected %i, found %i", + spec->min_length, nargs); else inform (input_location, "expected between %i and %i, found %i", spec->min_length, spec->max_length, nargs); |