diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2024-01-30 09:57:21 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2024-01-30 09:57:21 +0100 |
| commit | 26c9b95b9f712ff1f813351b5d45371620085221 (patch) | |
| tree | cc012350d1f601cd263c5d7d58da3109db4b1462 /gcc | |
| parent | 47b81161c98cf2ff5495d4aa6386cc3c87f9d27b (diff) | |
| download | gcc-26c9b95b9f712ff1f813351b5d45371620085221.zip gcc-26c9b95b9f712ff1f813351b5d45371620085221.tar.gz gcc-26c9b95b9f712ff1f813351b5d45371620085221.tar.bz2 | |
except: Fix __builtin_eh_return_data_regno (-42) expansion [PR101195]
The expansion of this builtin emits an error if the argument is not
INTEGER_CST, otherwise uses tree_to_uhwi on the argument (which is declared
int) and then uses EH_RETURN_DATA_REGNO macro which on most targets returns
INVALID_REGNUM for all values but some small number (2 or 4); if it returns
INVALID_REGNUM, we silently expand to -1.
Now, I think the error for non-INTEGER_CST makes sense to catch when people
unintentionally don't call it with a constant (but, users shouldn't really
use this builtin anyway, it is for the unwinder only). Initially I thought
about emitting an error for the negative values as well on which
tree_to_uhwi otherwise ICEs, but given that the function will silently
expand to -1 for INT_MAX - 1 or INT_MAX - 3 other values, I think treating
the negatives the same silently is fine too.
2024-01-30 Jakub Jelinek <jakub@redhat.com>
PR middle-end/101195
* except.cc (expand_builtin_eh_return_data_regno): If which doesn't
fit into unsigned HOST_WIDE_INT, return constm1_rtx.
* gcc.dg/pr101195.c: New test.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/except.cc | 3 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr101195.c | 8 |
2 files changed, 11 insertions, 0 deletions
diff --git a/gcc/except.cc b/gcc/except.cc index 9277a9a..2080fcc 100644 --- a/gcc/except.cc +++ b/gcc/except.cc @@ -2167,6 +2167,9 @@ expand_builtin_eh_return_data_regno (tree exp) return constm1_rtx; } + if (!tree_fits_uhwi_p (which)) + return constm1_rtx; + iwhich = tree_to_uhwi (which); iwhich = EH_RETURN_DATA_REGNO (iwhich); if (iwhich == INVALID_REGNUM) diff --git a/gcc/testsuite/gcc.dg/pr101195.c b/gcc/testsuite/gcc.dg/pr101195.c new file mode 100644 index 0000000..7b219f8 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr101195.c @@ -0,0 +1,8 @@ +/* PR middle-end/101195 */ +/* { dg-do compile } */ + +int +foo (void) +{ + return __builtin_eh_return_data_regno (-42); +} |