diff options
| author | Andrew Pinski <pinskia@gmail.com> | 2023-10-19 05:42:02 +0000 |
|---|---|---|
| committer | Andrew Pinski <pinskia@gmail.com> | 2023-10-19 16:52:02 +0000 |
| commit | 2454ba9e2d1ce2d1b9b2b46f6111e022364bf9b5 (patch) | |
| tree | 5576de61d9e9adc1514e66b9da5ae275de8ab0a2 /gcc | |
| parent | 9f33e4c50ee92a2053f52e5eb8f205afa54d4cb0 (diff) | |
| download | gcc-2454ba9e2d1ce2d1b9b2b46f6111e022364bf9b5.zip gcc-2454ba9e2d1ce2d1b9b2b46f6111e022364bf9b5.tar.gz gcc-2454ba9e2d1ce2d1b9b2b46f6111e022364bf9b5.tar.bz2 | |
c: Fix ICE when an argument was an error mark [PR100532]
In the case of convert_argument, we would return the same expression
back rather than error_mark_node after the error message about
trying to convert to an incomplete type. This causes issues in
the gimplfier trying to see if another conversion is needed.
The code here dates back to before the revision history too so
it might be the case it never noticed we should return an error_mark_node.
Bootstrapped and tested on x86_64-linux-gnu with no regressions.
PR c/100532
gcc/c/ChangeLog:
* c-typeck.cc (convert_argument): After erroring out
about an incomplete type return error_mark_node.
gcc/testsuite/ChangeLog:
* gcc.dg/pr100532-1.c: New test.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/c/c-typeck.cc | 2 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr100532-1.c | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc index f39dc71..f7ce13a 100644 --- a/gcc/c/c-typeck.cc +++ b/gcc/c/c-typeck.cc @@ -3367,7 +3367,7 @@ convert_argument (location_t ploc, tree function, tree fundecl, { error_at (ploc, "type of formal parameter %d is incomplete", parmnum + 1); - return val; + return error_mark_node; } /* Optionally warn about conversions that differ from the default diff --git a/gcc/testsuite/gcc.dg/pr100532-1.c b/gcc/testsuite/gcc.dg/pr100532-1.c new file mode 100644 index 0000000..81e37c6 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr100532-1.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ +/* PR c/100532 */ + +typedef __SIZE_TYPE__ size_t; +void *memcpy(void[], const void *, size_t); /* { dg-error "declaration of type name" } */ +void c(void) { memcpy(c, "a", 2); } /* { dg-error "type of formal parameter" } */ + |