aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorEric Botcazou <ebotcazou@adacore.com>2020-11-11 13:53:01 +0100
committerEric Botcazou <ebotcazou@adacore.com>2020-11-11 13:55:09 +0100
commit1f8fc1f458c4a66618c35d8e292fff6e9dce9f12 (patch)
tree540980b5d5baef54b3848408f3ba3ac8b6ede40f /gcc
parent4ac93608d7e33a3e10bbd8d50259bc00a7d01237 (diff)
downloadgcc-1f8fc1f458c4a66618c35d8e292fff6e9dce9f12.zip
gcc-1f8fc1f458c4a66618c35d8e292fff6e9dce9f12.tar.gz
gcc-1f8fc1f458c4a66618c35d8e292fff6e9dce9f12.tar.bz2
Fix internal error with Shift_Right operator on signed type
This is a regression present on the mainline and 10 branch in the form of an ICE with a shift operator applied to a variable of a signed type, and which is caused by a type mismatch. gcc/ada/ChangeLog: * gcc-interface/trans.c (gnat_to_gnu) <N_Op_Shift>: Also convert GNU_MAX_SHIFT if the type of the operation has been changed. * gcc-interface/utils.c (can_materialize_object_renaming_p): Add pair of missing parentheses. gcc/testsuite/ChangeLog: * gnat.dg/shift1.adb: New test.
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ada/gcc-interface/trans.c2
-rw-r--r--gcc/ada/gcc-interface/utils.c2
-rw-r--r--gcc/testsuite/gnat.dg/shift1.adb15
3 files changed, 18 insertions, 1 deletions
diff --git a/gcc/ada/gcc-interface/trans.c b/gcc/ada/gcc-interface/trans.c
index 059e1a4..d0663a2 100644
--- a/gcc/ada/gcc-interface/trans.c
+++ b/gcc/ada/gcc-interface/trans.c
@@ -7085,6 +7085,8 @@ gnat_to_gnu (Node_Id gnat_node)
if (TREE_CODE (gnu_lhs) == INTEGER_CST && ignore_lhs_overflow)
TREE_OVERFLOW (gnu_lhs) = TREE_OVERFLOW (gnu_old_lhs);
gnu_rhs = convert (gnu_type, gnu_rhs);
+ if (gnu_max_shift)
+ gnu_max_shift = convert (gnu_type, gnu_max_shift);
}
/* For signed integer addition, subtraction and multiplication, do an
diff --git a/gcc/ada/gcc-interface/utils.c b/gcc/ada/gcc-interface/utils.c
index d50872f..dfde06e 100644
--- a/gcc/ada/gcc-interface/utils.c
+++ b/gcc/ada/gcc-interface/utils.c
@@ -5837,7 +5837,7 @@ can_materialize_object_renaming_p (Node_Id expr)
{
expr = Original_Node (expr);
- switch Nkind (expr)
+ switch (Nkind (expr))
{
case N_Identifier:
case N_Expanded_Name:
diff --git a/gcc/testsuite/gnat.dg/shift1.adb b/gcc/testsuite/gnat.dg/shift1.adb
new file mode 100644
index 0000000..85a0fec
--- /dev/null
+++ b/gcc/testsuite/gnat.dg/shift1.adb
@@ -0,0 +1,15 @@
+-- { dg-do compile }
+-- { dg-options "-gnatws" }
+
+procedure Shift1 is
+
+ type T_Integer_8 is range -2 ** 7 .. 2 ** 7 - 1
+ with Size => 8;
+
+ pragma Provide_Shift_Operators (T_Integer_8);
+
+ X : T_Integer_8;
+
+begin
+ X := Shift_Right (X, 1);
+end;