aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorLiam Naddell <liamnprg@gmail.com>2024-12-17 11:48:03 -0500
committerCohenArthur <arthur.cohen@embecosm.com>2025-01-02 09:34:36 +0000
commit198d3ee34fbeec1749c184e30cc13b3d323f90dc (patch)
tree4ab9f1ca24ddbd490b63dfa4a004622e42e9199d /gcc
parent62058776ed9efe98b1c3677383bc82db04aa4608 (diff)
downloadgcc-198d3ee34fbeec1749c184e30cc13b3d323f90dc.zip
gcc-198d3ee34fbeec1749c184e30cc13b3d323f90dc.tar.gz
gcc-198d3ee34fbeec1749c184e30cc13b3d323f90dc.tar.bz2
Fix NR2.0 compiler ICE caused by Generics in Enums
gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc: Change the late name resolver to enter proper lexical scope during typechecking * resolve/rust-late-name-resolver-2.0.h: Add needed prototype to header * resolve/rust-toplevel-name-resolver-2.0.cc: Add generic parameters to enum's scoped RIB to allow for proper name resolution on types. gcc/testsuite/ChangeLog: * rust/compile/issue-3304.rs: Add small test for generics+enums combination for NR2.0 Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
Diffstat (limited to 'gcc')
-rw-r--r--gcc/rust/resolve/rust-late-name-resolver-2.0.cc7
-rw-r--r--gcc/rust/resolve/rust-late-name-resolver-2.0.h1
-rw-r--r--gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc9
-rw-r--r--gcc/testsuite/rust/compile/issue-3304.rs10
4 files changed, 27 insertions, 0 deletions
diff --git a/gcc/rust/resolve/rust-late-name-resolver-2.0.cc b/gcc/rust/resolve/rust-late-name-resolver-2.0.cc
index 6d450bc..a331e24 100644
--- a/gcc/rust/resolve/rust-late-name-resolver-2.0.cc
+++ b/gcc/rust/resolve/rust-late-name-resolver-2.0.cc
@@ -296,6 +296,13 @@ Late::visit (AST::StructStruct &s)
}
void
+Late::visit (AST::Enum &s)
+{
+ auto s_vis = [this, &s] () { AST::DefaultASTVisitor::visit (s); };
+ ctx.scoped (Rib::Kind::Item, s.get_node_id (), s_vis);
+}
+
+void
Late::visit (AST::StructExprStruct &s)
{
auto resolved = ctx.types.resolve_path (s.get_struct_name ().get_segments ());
diff --git a/gcc/rust/resolve/rust-late-name-resolver-2.0.h b/gcc/rust/resolve/rust-late-name-resolver-2.0.h
index 98cf092..7260f99 100644
--- a/gcc/rust/resolve/rust-late-name-resolver-2.0.h
+++ b/gcc/rust/resolve/rust-late-name-resolver-2.0.h
@@ -52,6 +52,7 @@ public:
void visit (AST::StructExprStructBase &) override;
void visit (AST::StructExprStructFields &) override;
void visit (AST::StructStruct &) override;
+ void visit (AST::Enum &) override;
void visit (AST::GenericArgs &) override;
void visit (AST::GenericArg &);
diff --git a/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc b/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc
index 01c5d26..8fa4809 100644
--- a/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc
+++ b/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc
@@ -332,6 +332,15 @@ TopLevel::visit (AST::EnumItemDiscriminant &variant)
void
TopLevel::visit (AST::Enum &enum_item)
{
+ auto generic_vis = [this, &enum_item] () {
+ for (auto &g : enum_item.get_generic_params ())
+ {
+ g->accept_vis (*this);
+ }
+ };
+
+ ctx.scoped (Rib::Kind::Item, enum_item.get_node_id (), generic_vis);
+
insert_or_error_out (enum_item.get_identifier (), enum_item,
Namespace::Types);
diff --git a/gcc/testsuite/rust/compile/issue-3304.rs b/gcc/testsuite/rust/compile/issue-3304.rs
new file mode 100644
index 0000000..6ab614f
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-3304.rs
@@ -0,0 +1,10 @@
+// { dg-additional-options "-frust-name-resolution-2.0" }
+#[lang = "sized"]
+trait Sized {}
+
+pub enum ROption<T> {
+ RSome(T),
+ RNone,
+}
+
+fn main() {}