aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorGeorg-Johann Lay <avr@gjlay.de>2024-05-03 18:47:50 +0200
committerGeorg-Johann Lay <avr@gjlay.de>2024-05-06 19:10:08 +0200
commit08e752e72363ae7fd5a5fcb70913a0f7b240387b (patch)
treede21531f9f59dc2abbe40119d10632ce88b83678 /gcc
parent0e12aa6c26a9566f5b1a9b6d111a9e27507e213d (diff)
downloadgcc-08e752e72363ae7fd5a5fcb70913a0f7b240387b.zip
gcc-08e752e72363ae7fd5a5fcb70913a0f7b240387b.tar.gz
gcc-08e752e72363ae7fd5a5fcb70913a0f7b240387b.tar.bz2
AVR: ipa/92606 - Don't optimize PROGMEM data against non-PROGMEM.
ipa/92606: Inter-procedural analysis optimizes data across address-spaces and PROGMEM. As of v14, the PROGMEM part is still not fixed (and there is still no target hook as proposed in PR92932). Just disable respective bogus optimization. PR ipa/92606 gcc/ * config/avr/avr.cc (avr_option_override): Set flag_ipa_icf_variables = 0. gcc/testsuite/ * gcc.target/avr/torture/pr92606.c: New test.
Diffstat (limited to 'gcc')
-rw-r--r--gcc/config/avr/avr.cc6
-rw-r--r--gcc/testsuite/gcc.target/avr/torture/pr92606.c57
2 files changed, 63 insertions, 0 deletions
diff --git a/gcc/config/avr/avr.cc b/gcc/config/avr/avr.cc
index 510e4ce..74924ab 100644
--- a/gcc/config/avr/avr.cc
+++ b/gcc/config/avr/avr.cc
@@ -1140,6 +1140,12 @@ avr_option_override (void)
if (targetm.addr_space.zero_address_valid (ADDR_SPACE_GENERIC))
flag_delete_null_pointer_checks = 0;
+ /* PR ipa/92606: Inter-procedural analysis optimizes data across
+ address-spaces and PROGMEM. As of v14, the PROGMEM part is
+ still not fixed (and there is still no target hook as proposed
+ in PR92932). Just disable respective bogus optimization. */
+ flag_ipa_icf_variables = 0;
+
if (flag_pic == 1)
warning (OPT_fpic, "%<-fpic%> is not supported");
if (flag_pic == 2)
diff --git a/gcc/testsuite/gcc.target/avr/torture/pr92606.c b/gcc/testsuite/gcc.target/avr/torture/pr92606.c
new file mode 100644
index 0000000..cc07128
--- /dev/null
+++ b/gcc/testsuite/gcc.target/avr/torture/pr92606.c
@@ -0,0 +1,57 @@
+/* { dg-do run } */
+
+typedef __UINT16_TYPE__ uint16_t;
+typedef __UINT32_TYPE__ uint32_t;
+
+typedef uint32_t T;
+
+#define NI __attribute__((noinline,noclone))
+
+
+#ifndef __AVR_TINY__
+#define read_u32(X) \
+ (__extension__( \
+ { \
+ uint16_t __addr16 = (uint16_t)(X); \
+ uint32_t __result; \
+ __asm__ __volatile__ ("lpm %A0, Z+" "\n\t" \
+ "lpm %B0, Z+" "\n\t" \
+ "lpm %C0, Z+" "\n\t" \
+ "lpm %D0, Z" "\n\t" \
+ : "=r" (__result), "+z" (__addr16)); \
+ __result; \
+ }))
+#else
+NI uint32_t read_u32 (const uint32_t *p)
+{
+ return *p;
+}
+#endif
+
+static const __attribute((progmem)) T xyz_prog[] = { 123, 123, 123 };
+T xyz[] = { 123, 123, 123 };
+volatile int x = 0;
+
+NI void prf (T f)
+{
+ if (f != 123)
+ __builtin_abort();
+}
+
+NI void func_progmem()
+{
+ prf (read_u32 (&xyz_prog[0]));
+}
+
+NI void func_ram()
+{
+ prf (xyz[x]);
+}
+
+int main (void)
+{
+ func_progmem();
+ func_ram();
+
+ return 0;
+}