diff options
| author | Harald Anlauf <anlauf@gmx.de> | 2020-06-24 21:03:47 +0200 |
|---|---|---|
| committer | Giuliano Belinassi <giuliano.belinassi@usp.br> | 2020-08-17 13:14:48 -0300 |
| commit | 9836363c22a283633b36b16b95ea2de97e91d62f (patch) | |
| tree | 117a5963bebad92731f25b77696b2e5033c5f969 /gcc | |
| parent | 1ce17beb46733c594b388abb12cb0300c188db84 (diff) | |
| download | gcc-9836363c22a283633b36b16b95ea2de97e91d62f.zip gcc-9836363c22a283633b36b16b95ea2de97e91d62f.tar.gz gcc-9836363c22a283633b36b16b95ea2de97e91d62f.tar.bz2 | |
PR fortran/95827 - Buffer overflows with submodules and coarrays
With submodules and coarrays, name mangling results in long internal
symbols. Enlarge internal buffer.
gcc/fortran/
PR fortran/95827
* iresolve.c (gfc_get_string): Enlarge internal buffer used in
generating the mangled name.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/fortran/iresolve.c | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gfortran.dg/pr95827.f90 | 14 |
2 files changed, 16 insertions, 2 deletions
diff --git a/gcc/fortran/iresolve.c b/gcc/fortran/iresolve.c index aa9bb32..7376961 100644 --- a/gcc/fortran/iresolve.c +++ b/gcc/fortran/iresolve.c @@ -47,8 +47,8 @@ along with GCC; see the file COPYING3. If not see const char * gfc_get_string (const char *format, ...) { - /* Provide sufficient space to hold "_F.symbol.symbol_MOD_symbol". */ - char temp_name[4 + 2*GFC_MAX_SYMBOL_LEN + 5 + GFC_MAX_SYMBOL_LEN + 1]; + /* Provide sufficient space for "_F.caf_token__symbol.symbol_MOD_symbol". */ + char temp_name[15 + 2*GFC_MAX_SYMBOL_LEN + 5 + GFC_MAX_SYMBOL_LEN + 1]; const char *str; va_list ap; tree ident; diff --git a/gcc/testsuite/gfortran.dg/pr95827.f90 b/gcc/testsuite/gfortran.dg/pr95827.f90 new file mode 100644 index 0000000..545e344 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr95827.f90 @@ -0,0 +1,14 @@ +! { dg-do compile } +! { dg-options "-fcoarray=lib -fsecond-underscore" } +! PR fortran/95827 - ICE in gfc_get_string, at fortran/iresolve.c:70 + +module m2345678901234567890123456789012345678901234567890123456789_123 + interface + module subroutine s2345678901234567890123456789012345678901234567890123456789_123 + end + end interface +end +submodule(m2345678901234567890123456789012345678901234567890123456789_123) & + n2345678901234567890123456789012345678901234567890123456789_123 + integer :: x2345678901234567890123456789012345678901234567890123456789_123[*] +end |