diff options
| author | Steven G. Kargl <kargl@gcc.gnu.org> | 2019-08-17 14:23:10 +0000 |
|---|---|---|
| committer | Steven G. Kargl <kargl@gcc.gnu.org> | 2019-08-17 14:23:10 +0000 |
| commit | 4f81c2a3c54d8ea9ebd7c703eef9f6d09088eb29 (patch) | |
| tree | ed13385cd80efbcefdd9826bfb5250862c4a9815 /gcc | |
| parent | 1e67491a0db526fa3137cf6576dde13cd785d364 (diff) | |
| download | gcc-4f81c2a3c54d8ea9ebd7c703eef9f6d09088eb29.zip gcc-4f81c2a3c54d8ea9ebd7c703eef9f6d09088eb29.tar.gz gcc-4f81c2a3c54d8ea9ebd7c703eef9f6d09088eb29.tar.bz2 | |
re PR fortran/91471 (f951: internal compiler error: gfc_variable_attr(): Bad array reference)
2019-08-17 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/91471
* primary.c (gfc_variable_attr): Remove a gfc_internal_error(),
which cannot be reached by conforming Fortran code, but seems to
be reachable from nonconforming Fortran code. Treat the AR_UNKNOWN
case as a no-op.
2019-08-17 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/91471
* gfortran.dg/pr91471.f90: New test.
From-SVN: r274603
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/fortran/ChangeLog | 8 | ||||
| -rw-r--r-- | gcc/fortran/primary.c | 10 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gfortran.dg/pr91471.f90 | 14 |
4 files changed, 31 insertions, 6 deletions
diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index a3b9e6b..130c3df 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,11 @@ +2019-08-17 Steven G. Kargl <kargl@gcc.gnu.org> + + PR fortran/91471 + * primary.c (gfc_variable_attr): Remove a gfc_internal_error(), + which cannot be reached by conforming Fortran code, but seems to + be reachable from nonconforming Fortran code. Treat the AR_UNKNOWN + case as a no-op. + 2019-08-17 Janne Blomqvist <jb@gcc.gnu.org> PR fortran/68401 diff --git a/gcc/fortran/primary.c b/gcc/fortran/primary.c index 1cc1018..a33a797 100644 --- a/gcc/fortran/primary.c +++ b/gcc/fortran/primary.c @@ -2597,12 +2597,10 @@ gfc_variable_attr (gfc_expr *expr, gfc_typespec *ts) break; case AR_UNKNOWN: - /* If any of start, end or stride is not integer, there will - already have been an error issued. */ - int errors; - gfc_get_errors (NULL, &errors); - if (errors == 0) - gfc_internal_error ("gfc_variable_attr(): Bad array reference"); + /* For standard conforming code, AR_UNKNOWN should not happen. + For nonconforming code, gfortran can end up here. Treat it + as a no-op. */ + break; } break; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 4652290..0a2bbc1 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-08-17 Steven G. Kargl <kargl@gcc.gnu.org> + + PR fortran/91471 + * gfortran.dg/pr91471.f90: New test. + 2019-08-16 Marek Polacek <polacek@redhat.com> PR c++/85827 diff --git a/gcc/testsuite/gfortran.dg/pr91471.f90 b/gcc/testsuite/gfortran.dg/pr91471.f90 new file mode 100644 index 0000000..fa79844 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr91471.f90 @@ -0,0 +1,14 @@ +! { dg-do compile } +! PR fortran/91471 +! Code contributed by Sameeran Joshi <SameeranJayant dot Joshi at amd dot com> +! +! This invalid code (x(1) is referenced, but never set) caused an ICE due +! to hitting a gfc_internal_error() in primary.c (gfc_variable_attr). The +! fix is to remove that gfc_internal_error(). +! +program dynamic + implicit none + integer, dimension(:), allocatable :: x + allocate(x(1)) + stop x(1) +end program dynamic |