diff options
| author | Richard Biener <rguenther@suse.de> | 2015-10-06 12:34:15 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2015-10-06 12:34:15 +0000 |
| commit | 0580f6a1a8eba90a82c83b8341f94d25529b25e9 (patch) | |
| tree | 48545297a0d21d21dfb61cfc0c4c986165b8f10b /gcc | |
| parent | badfb2fbefac5b03bc1731b07900e3e75d5c01f8 (diff) | |
| download | gcc-0580f6a1a8eba90a82c83b8341f94d25529b25e9.zip gcc-0580f6a1a8eba90a82c83b8341f94d25529b25e9.tar.gz gcc-0580f6a1a8eba90a82c83b8341f94d25529b25e9.tar.bz2 | |
re PR tree-optimization/67859 (ICE on valid code at -O2 and -O3 on x86_64-linux-gnu)
2015-10-06 Richard Biener <rguenther@suse.de>
PR tree-optimization/67859
* tree-ssa-pre.c (create_expression_by_pieces): Properly
discard not inserted stmts.
* gcc.dg/torture/pr67859.c: New testcase.
From-SVN: r228519
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/torture/pr67859.c | 15 | ||||
| -rw-r--r-- | gcc/tree-ssa-pre.c | 13 |
4 files changed, 35 insertions, 4 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6afa691..eb02d8b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-10-06 Richard Biener <rguenther@suse.de> + + PR tree-optimization/67859 + * tree-ssa-pre.c (create_expression_by_pieces): Properly + discard not inserted stmts. + 2015-10-06 Jonathan Wakely <jwakely@redhat.com> * doc/extend.texi (Template Instantiation): Reorder options and diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a931b24..8b27d2e 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-10-06 Richard Biener <rguenther@suse.de> + + PR tree-optimization/67859 + * gcc.dg/torture/pr67859.c: New testcase. + 2015-10-05 Kirill Yukhin <kirill.yukhin@intel.com> * gcc.target/i386/builtin_target.c: Add check for AES and PCLMUL. diff --git a/gcc/testsuite/gcc.dg/torture/pr67859.c b/gcc/testsuite/gcc.dg/torture/pr67859.c new file mode 100644 index 0000000..259b381 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr67859.c @@ -0,0 +1,15 @@ +/* { dg-do compile } */ + +int a, b, c; + +void +fn1 () +{ + b = c ? 0 : 1 << a; + b |= 0x9D7A5FD9; + for (;;) + { + int d = 1; + b &= (unsigned) d; + } +} diff --git a/gcc/tree-ssa-pre.c b/gcc/tree-ssa-pre.c index fb9ed02..c5af63d 100644 --- a/gcc/tree-ssa-pre.c +++ b/gcc/tree-ssa-pre.c @@ -2897,11 +2897,16 @@ create_expression_by_pieces (basic_block block, pre_expr expr, folded = gimple_convert (&forced_stmts, exprtype, folded); - /* If everything simplified to an exisiting SSA name or constant just - return that. */ - if (gimple_seq_empty_p (forced_stmts) - || is_gimple_min_invariant (folded)) + /* If there is nothing to insert, return the simplified result. */ + if (gimple_seq_empty_p (forced_stmts)) return folded; + /* If we simplified to a constant return it and discard eventually + built stmts. */ + if (is_gimple_min_invariant (folded)) + { + gimple_seq_discard (forced_stmts); + return folded; + } gcc_assert (TREE_CODE (folded) == SSA_NAME); |