diff options
| author | Martin Liska <mliska@suse.cz> | 2019-06-26 08:44:28 +0200 |
|---|---|---|
| committer | Martin Liska <marxin@gcc.gnu.org> | 2019-06-26 06:44:28 +0000 |
| commit | 02e18a0e8a922af6a09ef58922ac44bacd4eb5c6 (patch) | |
| tree | 550ff06d4657878ffce396f660b85429db500711 /gcc | |
| parent | 09039e9c723456cd008c7fa94ea772ee796cda2c (diff) | |
| download | gcc-02e18a0e8a922af6a09ef58922ac44bacd4eb5c6.zip gcc-02e18a0e8a922af6a09ef58922ac44bacd4eb5c6.tar.gz gcc-02e18a0e8a922af6a09ef58922ac44bacd4eb5c6.tar.bz2 | |
Fix missing else keyword seen with clang-static-analyzer:
2019-06-26 Martin Liska <mliska@suse.cz>
* bb-reorder.c (connect_better_edge_p): Add missing else
statement in the middle of if-else statements.
/home/marxin/Programming/gcc/gcc/bb-reorder.c:1031:2: warning: Value stored to 'is_better_edge' is never read
is_better_edge = true;
^ ~~~~
/home/marxin/Programming/gcc/gcc/bb-reorder.c:1034:2: warning: Value stored to 'is_better_edge' is never read
is_better_edge = false;
^ ~~~~~
From-SVN: r272670
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 12 | ||||
| -rw-r--r-- | gcc/bb-reorder.c | 2 |
2 files changed, 13 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7945fdc..fbaed7f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,15 @@ +2019-06-26 Martin Liska <mliska@suse.cz> + + * bb-reorder.c (connect_better_edge_p): Add missing else + statement in the middle of if-else statements. + +/home/marxin/Programming/gcc/gcc/bb-reorder.c:1031:2: warning: Value stored to 'is_better_edge' is never read + is_better_edge = true; + ^ ~~~~ +/home/marxin/Programming/gcc/gcc/bb-reorder.c:1034:2: warning: Value stored to 'is_better_edge' is never read + is_better_edge = false; + ^ ~~~~~ + 2019-06-25 Hongtao Liu <hongtao.liu@intel.com> H.J. Lu <hongjiu.lu@intel.com> Olga Makhotina <olga.makhotina@intel.com> diff --git a/gcc/bb-reorder.c b/gcc/bb-reorder.c index c21d204..0ac3914 100644 --- a/gcc/bb-reorder.c +++ b/gcc/bb-reorder.c @@ -1032,7 +1032,7 @@ connect_better_edge_p (const_edge e, bool src_index_p, int best_len, else if (e->count () < cur_best_edge->count ()) /* The edge has lower probability than the temporary best edge. */ is_better_edge = false; - if (e->probability > cur_best_edge->probability) + else if (e->probability > cur_best_edge->probability) /* The edge has higher probability than the temporary best edge. */ is_better_edge = true; else if (e->probability < cur_best_edge->probability) |