diff options
| author | Richard Biener <rguenther@suse.de> | 2022-07-01 15:32:30 +0200 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2022-07-04 09:09:45 +0200 |
| commit | d74d98784a9d0101aad8095d692193a74a2f62f6 (patch) | |
| tree | 4ebaef48701a23174797f9e3e573445dc7d70903 /gcc | |
| parent | 73f942c08deef3cce312263b3347f7a44dd44150 (diff) | |
| download | gcc-d74d98784a9d0101aad8095d692193a74a2f62f6.zip gcc-d74d98784a9d0101aad8095d692193a74a2f62f6.tar.gz gcc-d74d98784a9d0101aad8095d692193a74a2f62f6.tar.bz2 | |
tree-optimization/106055 - issue with autopar
When autopar uses graphites canonicalize_loop_closed_ssa it fails to
check whether propagation is allowed and thus it ends up messing up
abnormal constraints.
2022-07-01 Richard Biener <rguenther@suse.de>
PR tree-optimization/106055
* graphite.cc (canonicalize_loop_closed_ssa): Check whether
we can propagate.
* gcc.dg/graphite/pr106055.c: New testcase.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/graphite.cc | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/graphite/pr106055.c | 41 |
2 files changed, 45 insertions, 1 deletions
diff --git a/gcc/graphite.cc b/gcc/graphite.cc index a88b13c..fd4f7a1 100644 --- a/gcc/graphite.cc +++ b/gcc/graphite.cc @@ -57,6 +57,7 @@ along with GCC; see the file COPYING3. If not see #include "tree-ssa-loop-manip.h" #include "tree-ssa.h" #include "tree-into-ssa.h" +#include "tree-ssa-propagate.h" #include "graphite.h" /* Print global statistics to FILE. */ @@ -337,7 +338,9 @@ canonicalize_loop_closed_ssa (loop_p loop, edge e) /* Iterate over the next phis and remove duplicates. */ gsi_next (&gsi); while (!gsi_end_p (gsi)) - if (gimple_phi_arg_def (phi, 0) == gimple_phi_arg_def (gsi.phi (), 0)) + if (gimple_phi_arg_def (phi, 0) == gimple_phi_arg_def (gsi.phi (), 0) + && may_propagate_copy (gimple_phi_result (gsi.phi ()), + gimple_phi_result (phi))) { replace_uses_by (gimple_phi_result (gsi.phi ()), gimple_phi_result (phi)); diff --git a/gcc/testsuite/gcc.dg/graphite/pr106055.c b/gcc/testsuite/gcc.dg/graphite/pr106055.c new file mode 100644 index 0000000..22be62b --- /dev/null +++ b/gcc/testsuite/gcc.dg/graphite/pr106055.c @@ -0,0 +1,41 @@ +/* { dg-do compile } */ +/* { dg-options "-Os -floop-parallelize-all -fno-tree-dce" } */ + +__attribute__ ((returns_twice)) int +bar (void); + +void +quux (void); + +void +empty (void) +{ +} + +unsigned int +choose (unsigned int x, unsigned int y) +{ + return y ? x : 0; +} + +int +foo (int *p, unsigned int x, int y) +{ + unsigned int acc = 0; + + empty (); + + while (x) + { + bar (); + ++x; + } + + while (y) + acc += y; + + *p = choose (acc, 1); + quux (); + + return x; +} |