diff options
| author | Andrew Pinski <quic_apinski@quicinc.com> | 2024-01-18 10:40:04 -0800 |
|---|---|---|
| committer | Andrew Pinski <quic_apinski@quicinc.com> | 2024-01-24 09:49:24 -0800 |
| commit | d3ff08a3764f2047d02b35212fc4f1da9eb75c7b (patch) | |
| tree | 2f0c2534f67ffb5fdf6496c4cc26700e0f865135 /gcc | |
| parent | fb54b9772816968032518d4008be5090e0d95109 (diff) | |
| download | gcc-d3ff08a3764f2047d02b35212fc4f1da9eb75c7b.zip gcc-d3ff08a3764f2047d02b35212fc4f1da9eb75c7b.tar.gz gcc-d3ff08a3764f2047d02b35212fc4f1da9eb75c7b.tar.bz2 | |
aarch64: Fix __builtin_apply with -mgeneral-regs-only [PR113486]
The problem here is the builtin apply mechanism thinks the FP registers
are to be used due to get_raw_arg_mode not returning VOIDmode. This
fixes that oversight and the backend now returns VOIDmode for non-general-regs
if TARGET_GENERAL_REGS_ONLY is true.
Built and tested for aarch64-linux-gnu with no regressions.
PR target/113486
gcc/ChangeLog:
* config/aarch64/aarch64.cc (aarch64_get_reg_raw_mode): For
TARGET_GENERAL_REGS_ONLY, return VOIDmode for non-GP_REGNUM_P regno.
gcc/testsuite/ChangeLog:
* gcc.target/aarch64/builtin_apply-1.c: New test.
Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/config/aarch64/aarch64.cc | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c | 12 |
2 files changed, 16 insertions, 0 deletions
diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index c54b606..3d6dd98 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -7221,6 +7221,10 @@ aarch64_function_arg_boundary (machine_mode mode, const_tree type) static fixed_size_mode aarch64_get_reg_raw_mode (int regno) { + /* Don't use any non GP registers for __builtin_apply and + __builtin_return if general registers only mode is requested. */ + if (TARGET_GENERAL_REGS_ONLY && !GP_REGNUM_P (regno)) + return as_a <fixed_size_mode> (VOIDmode); if (TARGET_SVE && FP_REGNUM_P (regno)) /* Don't use the SVE part of the register for __builtin_apply and __builtin_return. The SVE registers aren't used by the normal PCS, diff --git a/gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c b/gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c new file mode 100644 index 0000000..d70abe0 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-mgeneral-regs-only" } */ +/* PR target/113486 */ + + +/* __builtin_apply should not use FP registers if + general registers only mode is requested. */ +void +foo (void) +{ + __builtin_apply (foo, 0, 0); +} |