diff options
| author | Volker Reichelt <reichelt@igpm.rwth-aachen.de> | 2006-08-05 23:26:38 +0000 |
|---|---|---|
| committer | Volker Reichelt <reichelt@gcc.gnu.org> | 2006-08-05 23:26:38 +0000 |
| commit | c0bcacec2d602672e56efcd6575a629dd22a41d1 (patch) | |
| tree | 28b338f7d84ae55e6304ba2806ea61a21fd326da /gcc | |
| parent | 85cad37c81a7c506c09cea90ff3cd4a15acacaaa (diff) | |
| download | gcc-c0bcacec2d602672e56efcd6575a629dd22a41d1.zip gcc-c0bcacec2d602672e56efcd6575a629dd22a41d1.tar.gz gcc-c0bcacec2d602672e56efcd6575a629dd22a41d1.tar.bz2 | |
re PR c/27721 (ICE using += with a function)
PR c/27721
* c-typeck.c (build_modify_expr): Test earlier for non-lvalues.
* gcc.dg/lvalue-4.c: New test.
From-SVN: r115955
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 3 | ||||
| -rw-r--r-- | gcc/c-typeck.c | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 3 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/lvalue-4.c | 8 |
4 files changed, 17 insertions, 3 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 72e1d46..0cbdf6d 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,8 @@ 2006-08-05 Volker Reichelt <reichelt@igpm.rwth-aachen.de> + PR c/27721 + * c-typeck.c (build_modify_expr): Test earlier for non-lvalues. + PR c/28136 * c-parser.c (c_parser_postfix_expression_after_paren_type): Robustify. diff --git a/gcc/c-typeck.c b/gcc/c-typeck.c index 31dadc6..ff27c97 100644 --- a/gcc/c-typeck.c +++ b/gcc/c-typeck.c @@ -3668,6 +3668,9 @@ build_modify_expr (tree lhs, enum tree_code modifycode, tree rhs) if (TREE_CODE (lhs) == ERROR_MARK || TREE_CODE (rhs) == ERROR_MARK) return error_mark_node; + if (!lvalue_or_else (lhs, lv_assign)) + return error_mark_node; + STRIP_TYPE_NOPS (rhs); newrhs = rhs; @@ -3681,9 +3684,6 @@ build_modify_expr (tree lhs, enum tree_code modifycode, tree rhs) newrhs = build_binary_op (modifycode, lhs, rhs, 1); } - if (!lvalue_or_else (lhs, lv_assign)) - return error_mark_node; - /* Give an error for storing in something that is 'const'. */ if (TREE_READONLY (lhs) || TYPE_READONLY (lhstype) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 99bbfc5..89f1d4a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2006-08-05 Volker Reichelt <reichelt@igpm.rwth-aachen.de> + PR c/27721 + * gcc.dg/lvalue-4.c: New test. + PR c/28136 * gcc.dg/init-bad-5.c: New test. diff --git a/gcc/testsuite/gcc.dg/lvalue-4.c b/gcc/testsuite/gcc.dg/lvalue-4.c new file mode 100644 index 0000000..bc92901 --- /dev/null +++ b/gcc/testsuite/gcc.dg/lvalue-4.c @@ -0,0 +1,8 @@ +/* PR c/27721 */ +/* { dg-do compile } */ + +void foo() +{ + int i(); + i += 0; /* { dg-error "lvalue required" } */ +} |