aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorkonglin1 <lingling.kong@intel.com>2024-05-09 09:48:56 +0800
committerkonglin1 <lingling.kong@intel.com>2024-05-09 09:49:02 +0800
commitbaf1a677955a4dcfffe8d93966900af96600d642 (patch)
tree18f95b52879239a822fa86e5740bb52867734174 /gcc
parentce51e6727c9d69bbab0e766c449e60fd41f5f2f9 (diff)
downloadgcc-baf1a677955a4dcfffe8d93966900af96600d642.zip
gcc-baf1a677955a4dcfffe8d93966900af96600d642.tar.gz
gcc-baf1a677955a4dcfffe8d93966900af96600d642.tar.bz2
i386: fix ix86_hardreg_mov_ok with lra_in_progress
Originally eliminate_regs_in_insnit will transform (parallel [ (set (reg:QI 130) (plus:QI (subreg:QI (reg:DI 19 frame) 0) (const_int 96))) (clobber (reg:CC 17 flag))]) {*addqi_1} to (set (reg:QI 130) (subreg:QI (reg:DI 19 frame) 0)) {*movqi_internal} when verify_changes. But with No Flags add, it transforms (set (reg:QI 5 di) (plus:QI (subreg:QI (reg:DI 19 frame) 0) (const_int 96))) {*addqi_1_nf} to (set (reg:QI 5 di) (subreg:QI (reg:DI 19 frame) 0)) {*addqi_1_nf}. there is no extra clobbers at the end, and its dest reg just is a hardreg. For ix86_hardreg_mov_ok, it returns false. So it fails to update insn and causes the ICE when transform to movqi_internal. But actually it is ok and safe for ix86_hardreg_mov_ok when lra_in_progress. And tested the spec2017, the performance was not affected. gcc/ChangeLog: * config/i386/i386.cc (ix86_hardreg_mov_ok): Relax hard reg mov restriction when lra in progress.
Diffstat (limited to 'gcc')
-rw-r--r--gcc/config/i386/i386.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
index c2df4ab..54c6c44 100644
--- a/gcc/config/i386/i386.cc
+++ b/gcc/config/i386/i386.cc
@@ -20355,7 +20355,8 @@ ix86_hardreg_mov_ok (rtx dst, rtx src)
? standard_sse_constant_p (src, GET_MODE (dst))
: x86_64_immediate_operand (src, GET_MODE (dst)))
&& ix86_class_likely_spilled_p (REGNO_REG_CLASS (REGNO (dst)))
- && !reload_completed)
+ && !reload_completed
+ && !lra_in_progress)
return false;
return true;
}