diff options
| author | Vladimir N. Makarov <vmakarov@redhat.com> | 2024-03-19 16:57:11 -0400 |
|---|---|---|
| committer | Vladimir N. Makarov <vmakarov@redhat.com> | 2024-03-19 16:57:56 -0400 |
| commit | 9c91f8a88b2db50c8faf70786d3cef27b39ac9fc (patch) | |
| tree | ac8a7c1fb754d630ee3b35c7a283538c71cc60c6 /gcc | |
| parent | c92076aa5345b6a5523b4e193dcc98fe9743b228 (diff) | |
| download | gcc-9c91f8a88b2db50c8faf70786d3cef27b39ac9fc.zip gcc-9c91f8a88b2db50c8faf70786d3cef27b39ac9fc.tar.gz gcc-9c91f8a88b2db50c8faf70786d3cef27b39ac9fc.tar.bz2 | |
[PR99829][LRA]: Fixing LRA ICE on arm
LRA removed insn setting equivalence to memory whose output was
reloaded. This resulted in writing an uninitiated value to the memory
which triggered assert in LRA code checking the final generated code.
This patch fixes the problem. Comment in the patch contains more
details about the problem and its solution.
gcc/ChangeLog:
PR target/99829
* lra-constraints.cc (lra_constraints): Prevent removing insn
with reverse equivalence to memory if the memory was reloaded.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/lra-constraints.cc | 26 |
1 files changed, 18 insertions, 8 deletions
diff --git a/gcc/lra-constraints.cc b/gcc/lra-constraints.cc index 0ae81c1..10e3d4e 100644 --- a/gcc/lra-constraints.cc +++ b/gcc/lra-constraints.cc @@ -5213,7 +5213,7 @@ lra_constraints (bool first_p) bool changed_p; int i, hard_regno, new_insns_num; unsigned int min_len, new_min_len, uid; - rtx set, x, reg, dest_reg; + rtx set, x, reg, nosubreg_dest; rtx_insn *original_insn; basic_block last_bb; bitmap_iterator bi; @@ -5377,14 +5377,14 @@ lra_constraints (bool first_p) { if ((set = single_set (curr_insn)) != NULL_RTX) { - dest_reg = SET_DEST (set); + nosubreg_dest = SET_DEST (set); /* The equivalence pseudo could be set up as SUBREG in a case when it is a call restore insn in a mode different from the pseudo mode. */ - if (GET_CODE (dest_reg) == SUBREG) - dest_reg = SUBREG_REG (dest_reg); - if ((REG_P (dest_reg) - && (x = get_equiv (dest_reg)) != dest_reg + if (GET_CODE (nosubreg_dest) == SUBREG) + nosubreg_dest = SUBREG_REG (nosubreg_dest); + if ((REG_P (nosubreg_dest) + && (x = get_equiv (nosubreg_dest)) != nosubreg_dest /* Remove insns which set up a pseudo whose value cannot be changed. Such insns might be not in init_insns because we don't update equiv data @@ -5403,11 +5403,21 @@ lra_constraints (bool first_p) up the equivalence. */ || in_list_p (curr_insn, ira_reg_equiv - [REGNO (dest_reg)].init_insns))) + [REGNO (nosubreg_dest)].init_insns))) || (((x = get_equiv (SET_SRC (set))) != SET_SRC (set)) && in_list_p (curr_insn, ira_reg_equiv - [REGNO (SET_SRC (set))].init_insns))) + [REGNO (SET_SRC (set))].init_insns) + /* This is a reverse equivalence to memory (see ira.cc) + in store insn. We can reload all the destination and + have an output reload which is a store to memory. If + we just remove the insn, we will have the output + reload storing an undefined value to the memory. + Check that we did not reload the memory to prevent a + wrong code generation. We could implement using the + equivalence still in such case but doing this is not + worth the efforts as such case is very rare. */ + && MEM_P (nosubreg_dest))) { /* This is equiv init insn of pseudo which did not get a hard register -- remove the insn. */ |