aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorGabriel Dos Reis <gdr@integrable-solutions.net>2006-11-20 01:03:49 +0000
committerGabriel Dos Reis <gdr@gcc.gnu.org>2006-11-20 01:03:49 +0000
commit7f420d0d6459fdef0017363d95837cdaee9384fa (patch)
tree6684737f9050acf56dc8122efce5e084fa2b8824 /gcc
parente5dfa5b1bec2b9188d049b855077267bfa52b365 (diff)
downloadgcc-7f420d0d6459fdef0017363d95837cdaee9384fa.zip
gcc-7f420d0d6459fdef0017363d95837cdaee9384fa.tar.gz
gcc-7f420d0d6459fdef0017363d95837cdaee9384fa.tar.bz2
re PR c++/8586 (-Wwrite-strings should be included in -Wall)
2006-11-19 Gabriel Dos Reis <gdr@integrable-solutions.net> PR c++/8586 * c-opts.c (c_common_handle_option): Enable -Wwrite-strings if -Wall. testsuite/ 2006-11-19 Gabriel Dos Reis <gdr@integrable-solutions.net> PR c++/8586 * g++.dg/warn/Wall-write-strings.C: New. From-SVN: r119009
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ChangeLog5
-rw-r--r--gcc/c-opts.c2
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/g++.dg/warn/Wall-write-strings.C7
4 files changed, 19 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 4af29a5..4496ea2 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2006-11-19 Gabriel Dos Reis <gdr@integrable-solutions.net>
+
+ PR c++/8586
+ * c-opts.c (c_common_handle_option): Enable -Wwrite-strings if -Wall.
+
2006-11-19 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
PR target/29114
diff --git a/gcc/c-opts.c b/gcc/c-opts.c
index 1abb374..36026fd 100644
--- a/gcc/c-opts.c
+++ b/gcc/c-opts.c
@@ -416,6 +416,8 @@ c_common_handle_option (size_t scode, const char *arg, int value)
/* C++-specific warnings. */
warn_reorder = value;
warn_nontemplate_friend = value;
+ if (value > 0)
+ warn_write_strings = true;
}
cpp_opts->warn_trigraphs = value;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a44c291..f014dbb 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2006-11-19 Gabriel Dos Reis <gdr@integrable-solutions.net>
+
+ PR c++/8586
+ * g++.dg/warn/Wall-write-strings.C: New.
+
2006-11-19 Erik Edelmann <eedelman@gcc.gnu.org>
* gfortran.dg/alloc_comp_constraint_5.f90: New.
diff --git a/gcc/testsuite/g++.dg/warn/Wall-write-strings.C b/gcc/testsuite/g++.dg/warn/Wall-write-strings.C
new file mode 100644
index 0000000..e380b32
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wall-write-strings.C
@@ -0,0 +1,7 @@
+// PR 8586
+// { dg-do compile }
+// { dg-options "-Wall" }
+
+char* foo = "foo"; // { dg-warning "" }
+const char* bar = "bar";
+