diff options
| author | Zdenek Dvorak <ook@ucw.cz> | 2008-03-31 16:19:52 +0200 |
|---|---|---|
| committer | Zdenek Dvorak <rakdver@gcc.gnu.org> | 2008-03-31 14:19:52 +0000 |
| commit | 66f91b93db67ccea9e4d0ec803492e2dbd03974c (patch) | |
| tree | ffad40ad79ed9653b2a213a4f8b639c6da089e67 /gcc | |
| parent | 6b20c50ffe1de0c65fc196825236387da0b5ba34 (diff) | |
| download | gcc-66f91b93db67ccea9e4d0ec803492e2dbd03974c.zip gcc-66f91b93db67ccea9e4d0ec803492e2dbd03974c.tar.gz gcc-66f91b93db67ccea9e4d0ec803492e2dbd03974c.tar.bz2 | |
re PR rtl-optimization/35729 (const volatile variable access incorrectly hoisted out of loop)
PR rtl-optimization/35729
* loop-invariant.c (check_maybe_invariant): Disallow volatile memory
references.
* gcc.dg/pr35729.c: New test.
From-SVN: r133755
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/loop-invariant.c | 2 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr35729.c | 15 |
4 files changed, 27 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 0a426b1..a78eae8 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2008-03-31 Zdenek Dvorak <ook@ucw.cz> + + PR rtl-optimization/35729 + * loop-invariant.c (check_maybe_invariant): Disallow volatile memory + references. + 2008-03-31 H.J. Lu <hongjiu.lu@intel.com> PR target/32000 diff --git a/gcc/loop-invariant.c b/gcc/loop-invariant.c index ba1f288..64c16a9 100644 --- a/gcc/loop-invariant.c +++ b/gcc/loop-invariant.c @@ -206,7 +206,7 @@ check_maybe_invariant (rtx x) /* Just handle the most trivial case where we load from an unchanging location (most importantly, pic tables). */ - if (MEM_READONLY_P (x)) + if (MEM_READONLY_P (x) && !MEM_VOLATILE_P (x)) break; return false; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 3423800..6c208d9 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2008-03-31 Zdenek Dvorak <ook@ucw.cz> + + PR rtl-optimization/35729 + * gcc.dg/pr35729.c: New test. + 2008-03-31 H.J. Lu <hongjiu.lu@intel.com> PR target/32000 diff --git a/gcc/testsuite/gcc.dg/pr35729.c b/gcc/testsuite/gcc.dg/pr35729.c new file mode 100644 index 0000000..3ed40f4 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr35729.c @@ -0,0 +1,15 @@ +/* { dg-do compile } */ +/* { dg-options "-Os -fdump-rtl-loop2_invariant" } */ + +const volatile int g_361 = 3L; +volatile int g_2 = 0L; +void func_1 (void) +{ + for (g_2 = 0; g_2 > 10; g_2++) + { + int l_357 = g_361; + } +} + +/* { dg-final { scan-rtl-dump-times "Decided to move invariant" 0 "loop2_invariant" } } */ +/* { dg-final { cleanup-rtl-dump "loop2_invariant" } } */ |