aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorHarald Anlauf <anlauf@gmx.de>2022-01-12 21:24:49 +0100
committerHarald Anlauf <anlauf@gmx.de>2022-01-13 19:24:13 +0100
commit0b8464365b15ac108cd1d00d5bc56d229c1340de (patch)
tree9d08a0f4cecaf2bfa7ac8906a8926162b652d6b6 /gcc
parent386b15d6ef2db6bcca1369650f5456728e2d42f1 (diff)
downloadgcc-0b8464365b15ac108cd1d00d5bc56d229c1340de.zip
gcc-0b8464365b15ac108cd1d00d5bc56d229c1340de.tar.gz
gcc-0b8464365b15ac108cd1d00d5bc56d229c1340de.tar.bz2
Fortran: fix error recovery on bad structure constructor in DATA statement
gcc/fortran/ChangeLog: PR fortran/67804 * primary.c (gfc_match_structure_constructor): Recover from errors that occurred while checking for a valid structure constructor in a DATA statement. gcc/testsuite/ChangeLog: PR fortran/67804 * gfortran.dg/pr93604.f90: Adjust to changed diagnostics. * gfortran.dg/pr67804.f90: New test.
Diffstat (limited to 'gcc')
-rw-r--r--gcc/fortran/primary.c15
-rw-r--r--gcc/testsuite/gfortran.dg/pr67804.f9025
-rw-r--r--gcc/testsuite/gfortran.dg/pr93604.f902
3 files changed, 38 insertions, 4 deletions
diff --git a/gcc/fortran/primary.c b/gcc/fortran/primary.c
index fd4d6af..3f01f67 100644
--- a/gcc/fortran/primary.c
+++ b/gcc/fortran/primary.c
@@ -3364,6 +3364,7 @@ gfc_match_structure_constructor (gfc_symbol *sym, gfc_expr **result)
match m;
gfc_expr *e;
gfc_symtree *symtree;
+ bool t = true;
gfc_get_ha_sym_tree (sym->name, &symtree);
@@ -3394,10 +3395,18 @@ gfc_match_structure_constructor (gfc_symbol *sym, gfc_expr **result)
in the structure constructor must be a constant. Try to reduce the
expression here. */
if (gfc_in_match_data ())
- gfc_reduce_init_expr (e);
+ t = gfc_reduce_init_expr (e);
- *result = e;
- return MATCH_YES;
+ if (t)
+ {
+ *result = e;
+ return MATCH_YES;
+ }
+ else
+ {
+ gfc_free_expr (e);
+ return MATCH_ERROR;
+ }
}
diff --git a/gcc/testsuite/gfortran.dg/pr67804.f90 b/gcc/testsuite/gfortran.dg/pr67804.f90
new file mode 100644
index 0000000..e2009a5
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr67804.f90
@@ -0,0 +1,25 @@
+! { dg-do compile }
+! PR fortran/67804 - ICE on bad type in structure constructor in DATA statement
+! Contributed by G.Steinmetz
+
+program p
+ type t
+ character :: c
+ end type
+ type u
+ character, pointer :: c
+ end type
+ type(t) :: x0, x1, x2, x3, x4, x5, x6, x7, x8, x9
+ type(u) :: y6
+ data x0 /t('a')/ ! OK
+ data x1 /t(1)/ ! { dg-error "Cannot convert" }
+ data x2 /t(1.)/ ! { dg-error "Cannot convert" }
+ data x3 /t(1d1)/ ! { dg-error "Cannot convert" }
+ data x4 /t((0.,1.))/ ! { dg-error "Cannot convert" }
+ data x5 /t(.true.)/ ! { dg-error "Cannot convert" }
+ data x6 /t(null())/ ! { dg-error "neither a POINTER nor ALLOCATABLE" }
+ data x7 /t(['1'])/ ! { dg-error "The rank of the element" }
+ data x8 /t([1])/ ! { dg-error "Cannot convert" }
+ data x9 /t(z'0')/ ! { dg-error "Cannot convert" }
+ data y6 /u(null())/ ! OK
+end
diff --git a/gcc/testsuite/gfortran.dg/pr93604.f90 b/gcc/testsuite/gfortran.dg/pr93604.f90
index 2c695d3..4040155 100644
--- a/gcc/testsuite/gfortran.dg/pr93604.f90
+++ b/gcc/testsuite/gfortran.dg/pr93604.f90
@@ -5,6 +5,6 @@ program p
integer :: a
end type
type(t) :: x
- data x /t(z'1')/ ! { dg-error "cannot appear in a structure constructor" }
+ data x /t(z'1')/ ! { dg-error "BOZ" }
end