diff options
| author | Christophe Lyon <christophe.lyon@linaro.org> | 2023-12-21 10:51:10 +0000 |
|---|---|---|
| committer | Christophe Lyon <christophe.lyon@linaro.org> | 2023-12-22 10:24:56 +0000 |
| commit | 05d353b79441a708f43768383e2358c878ab727b (patch) | |
| tree | bfb79804525e2a15159726833635d4c35074f561 /gcc | |
| parent | c4d1d1adf75bcf4a91a936c0a33cfc5242cc4e1f (diff) | |
| download | gcc-05d353b79441a708f43768383e2358c878ab727b.zip gcc-05d353b79441a708f43768383e2358c878ab727b.tar.gz gcc-05d353b79441a708f43768383e2358c878ab727b.tar.bz2 | |
Allow overriding EXPECT
While investigating possible race conditions in the GCC testsuites
caused by bufferization issues, I wanted to investigate workarounds
similar to GDB's READ1 [1], and I noticed it was not always possible
to override EXPECT when running 'make check'.
This patch adds the missing support in various Makefiles.
I was not able to test the patch for all the libraries updated here,
but I confirmed it works as intended/needed for libstdc++.
libatomic, libitm, libgomp already work as intended because their
Makefiles do not have:
MAKEOVERRIDES=
Tested on (native) aarch64-linux-gnu, confirmed the patch introduces
the behaviour I want in gcc, g++, gfortran and libstdc++.
I updated (but could not test) libgm2, libphobos, libquadmath and
libssp for consistency since their Makefiles have MAKEOVERRIDES=
libffi, libgo, libsanitizer seem to need a similar update, but they
are imported from their respective upstream repo, so should not be
patched here.
[1] https://github.com/bminor/binutils-gdb/blob/master/gdb/testsuite/README#L269
2023-12-21 Christophe Lyon <christophe.lyon@linaro.org>
gcc/
* Makefile.in: Allow overriding EXEPCT.
libgm2/
* Makefile.am: Allow overriding EXEPCT.
* Makefile.in: Regenerate.
libphobos/
* Makefile.am: Allow overriding EXEPCT.
* Makefile.in: Regenerate.
libquadmath/
* Makefile.am: Allow overriding EXEPCT.
* Makefile.in: Regenerate.
libssp/
* Makefile.am: Allow overriding EXEPCT.
* Makefile.in: Regenerate.
libstdc++-v3/
* Makefile.am: Allow overriding EXEPCT.
* Makefile.in: Regenerate.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/Makefile.in | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 754eceb..9373800 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -4304,6 +4304,7 @@ $(lang_checks_parallel): site.exp vardots=`echo "$$variant" | sed 's,/,.,g'`; \ $(MAKE) TESTSUITEDIR="testsuite.$$vardots" \ RUNTESTFLAGS="--target_board=$$variant $(RUNTESTFLAGS)" \ + EXPECT=$(EXPECT) \ "$$target" TESTSUITEDIR = testsuite @@ -4369,6 +4370,7 @@ $(lang_checks_parallelized): check-% : site.exp GCC_RUNTEST_PARALLELIZE_DIR=`${PWD_COMMAND}`/$(TESTSUITEDIR)/$(check_p_tool)-parallel ; \ export GCC_RUNTEST_PARALLELIZE_DIR ; \ $(MAKE) TESTSUITEDIR="$(TESTSUITEDIR)" RUNTESTFLAGS="$(RUNTESTFLAGS)" \ + EXPECT=$(EXPECT) \ check-parallel-$* \ $(patsubst %,check-parallel-$*_%, $(check_p_subdirs)); \ sums= ; logs= ; \ @@ -4387,6 +4389,7 @@ $(lang_checks_parallelized): check-% : site.exp rm -rf $(TESTSUITEDIR)/$*-parallel || true; \ else \ $(MAKE) TESTSUITEDIR="$(TESTSUITEDIR)" RUNTESTFLAGS="$(RUNTESTFLAGS)" \ + EXPECT=$(EXPECT) \ check_$*_parallelize= check-parallel-$*; \ fi |