diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2023-01-18 11:08:14 -0800 |
|---|---|---|
| committer | H.J. Lu <(no_default)> | 2023-01-19 13:40:55 -0800 |
| commit | 77a67e3a9294c825ac1a2b205fbb266e7c29e82b (patch) | |
| tree | 705c675ebf3154055de915f9356bad5dd303d79a /gcc | |
| parent | 46644ec99cb355845b23bb1d02775c057ed8ee88 (diff) | |
| download | gcc-77a67e3a9294c825ac1a2b205fbb266e7c29e82b.zip gcc-77a67e3a9294c825ac1a2b205fbb266e7c29e82b.tar.gz gcc-77a67e3a9294c825ac1a2b205fbb266e7c29e82b.tar.bz2 | |
x86: Check invalid third argument to __builtin_ia32_prefetch
Check invalid third argument to __builtin_ia32_prefetch when expaning
__builtin_ia32_prefetch to avoid ICE later.
gcc/
PR target/108436
* config/i386/i386-expand.cc (ix86_expand_builtin): Check
invalid third argument to __builtin_ia32_prefetch.
gcc/testsuite/
* gcc.target/i386/pr108436.c: New test.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/config/i386/i386-expand.cc | 12 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/i386/pr108436.c | 15 |
2 files changed, 27 insertions, 0 deletions
diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc index 54f700c..e2e2d28 100644 --- a/gcc/config/i386/i386-expand.cc +++ b/gcc/config/i386/i386-expand.cc @@ -13175,6 +13175,12 @@ ix86_expand_builtin (tree exp, rtx target, rtx subtarget, if (INTVAL (op3) == 1) { + if (INTVAL (op2) < 2 || INTVAL (op2) > 3) + { + error ("invalid third argument"); + return const0_rtx; + } + if (TARGET_64BIT && TARGET_PREFETCHI && local_func_symbolic_operand (op0, GET_MODE (op0))) emit_insn (gen_prefetchi (op0, op2)); @@ -13195,6 +13201,12 @@ ix86_expand_builtin (tree exp, rtx target, rtx subtarget, op0 = copy_addr_to_reg (op0); } + if (INTVAL (op2) < 0 || INTVAL (op2) > 3) + { + warning (0, "invalid third argument to %<__builtin_ia32_prefetch%>; using zero"); + op2 = const0_rtx; + } + if (TARGET_3DNOW || TARGET_PREFETCH_SSE || TARGET_PRFCHW || TARGET_PREFETCHWT1) emit_insn (gen_prefetch (op0, op1, op2)); diff --git a/gcc/testsuite/gcc.target/i386/pr108436.c b/gcc/testsuite/gcc.target/i386/pr108436.c new file mode 100644 index 0000000..d51f258 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr108436.c @@ -0,0 +1,15 @@ +/* { dg-do compile } */ +/* { dg-options "-mprefetchi" } */ + +int +foo (int a) +{ + return a + 1; +} + +void +bad (int *p) +{ + __builtin_ia32_prefetch (p, 0, 4, 0); /* { dg-warning "invalid third argument to '__builtin_ia32_prefetch'; using zero" } */ + __builtin_ia32_prefetch (foo, 0, 4, 1); /* { dg-error "invalid third argument" } */ +} |