diff options
| author | Alexandre Oliva <oliva@adacore.com> | 2023-11-29 04:00:28 -0300 |
|---|---|---|
| committer | Alexandre Oliva <oliva@gnu.org> | 2023-11-29 04:00:28 -0300 |
| commit | 71804526d3a71a8c0f189a89ce3aa615784bfd8b (patch) | |
| tree | e3d053600f3a444b702102e2bd11d8a77ede4f5f /gcc | |
| parent | 1ff6d9f7428b0668cd8ab0b3e3ab94f1d733124d (diff) | |
| download | gcc-71804526d3a71a8c0f189a89ce3aa615784bfd8b.zip gcc-71804526d3a71a8c0f189a89ce3aa615784bfd8b.tar.gz gcc-71804526d3a71a8c0f189a89ce3aa615784bfd8b.tar.bz2 | |
c++: for contracts, cdtors never return this
When targetm.cxx.cdtor_return_this() holds, cdtors have a
non-VOID_TYPE_P result, but IMHO this ABI implementation detail
shouldn't leak to the abstract language conceptual framework, in which
cdtors don't have return values. For contracts, specifically those
that establish postconditions on results, such a leakage is present,
and the present patch puts an end to it: with it, cdtors get an error
for result postconditions regardless of the ABI. This fixes
g++.dg/contracts/contracts-ctor-dtor2.C on arm-eabi.
for gcc/cp/ChangeLog
* contracts.cc (check_postcondition_result): Cope with
cdtor_return_this.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/contracts.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gcc/cp/contracts.cc b/gcc/cp/contracts.cc index 66d2298..035ca48 100644 --- a/gcc/cp/contracts.cc +++ b/gcc/cp/contracts.cc @@ -636,7 +636,11 @@ make_postcondition_variable (cp_expr id) bool check_postcondition_result (tree decl, tree type, location_t loc) { - if (VOID_TYPE_P (type)) + /* Do not be confused by targetm.cxx.cdtor_return_this (); + conceptually, cdtors have no return value. */ + if (VOID_TYPE_P (type) + || DECL_CONSTRUCTOR_P (decl) + || DECL_DESTRUCTOR_P (decl)) { error_at (loc, DECL_CONSTRUCTOR_P (decl) |