diff options
author | Jakub Jelinek <jakub@redhat.com> | 2019-02-28 08:17:49 +0100 |
---|---|---|
committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2019-02-28 08:17:49 +0100 |
commit | 66dcb747e8ba1f0ed6e0d49ed3d842b3e091609d (patch) | |
tree | f9e4f0bf17c9733435280d2b609d2b9ca4dca8f9 /gcc | |
parent | c2df3c99d5cafbb9774fc6e944fbd64aa17c03bb (diff) | |
download | gcc-66dcb747e8ba1f0ed6e0d49ed3d842b3e091609d.zip gcc-66dcb747e8ba1f0ed6e0d49ed3d842b3e091609d.tar.gz gcc-66dcb747e8ba1f0ed6e0d49ed3d842b3e091609d.tar.bz2 |
re PR c/89525 (inform messages from -Wbuiltin-declaration-mismatch even with -w)
PR c/89525
* c-typeck.c (convert_arguments): Call inform_declaration only if
the previous warning_at call returned true.
* gcc.dg/pr89525.c: New test.
From-SVN: r269274
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/c/ChangeLog | 6 | ||||
-rw-r--r-- | gcc/c/c-typeck.c | 18 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 3 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/pr89525.c | 11 |
4 files changed, 28 insertions, 10 deletions
diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog index 6b26ca0..ec60ed3 100644 --- a/gcc/c/ChangeLog +++ b/gcc/c/ChangeLog @@ -1,3 +1,9 @@ +2019-02-28 Jakub Jelinek <jakub@redhat.com> + + PR c/89525 + * c-typeck.c (convert_arguments): Call inform_declaration only if + the previous warning_at call returned true. + 2019-02-22 Thomas Schwinge <thomas@codesourcery.com> * c-parser.c (c_parser_oacc_shape_clause): Add loc formal diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c index 4811200..2de4d0f 100644 --- a/gcc/c/c-typeck.c +++ b/gcc/c/c-typeck.c @@ -3509,12 +3509,10 @@ convert_arguments (location_t loc, vec<location_t> arg_loc, tree typelist, if (builtin_type == void_type_node) { - warning_at (loc, OPT_Wbuiltin_declaration_mismatch, - "too many arguments to built-in function %qE " - "expecting %d", - function, parmnum); - - inform_declaration (fundecl); + if (warning_at (loc, OPT_Wbuiltin_declaration_mismatch, + "too many arguments to built-in function %qE " + "expecting %d", function, parmnum)) + inform_declaration (fundecl); builtin_typetail = NULL_TREE; } @@ -3651,10 +3649,10 @@ convert_arguments (location_t loc, vec<location_t> arg_loc, tree typelist, for (tree t = builtin_typetail; t; t = TREE_CHAIN (t)) ++nargs; - warning_at (loc, OPT_Wbuiltin_declaration_mismatch, - "too few arguments to built-in function %qE expecting %u", - function, nargs - 1); - inform_declaration (fundecl); + if (warning_at (loc, OPT_Wbuiltin_declaration_mismatch, + "too few arguments to built-in function %qE " + "expecting %u", function, nargs - 1)) + inform_declaration (fundecl); } return error_args ? -1 : (int) parmnum; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 21642de..c711829 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2019-02-28 Jakub Jelinek <jakub@redhat.com> + PR c/89525 + * gcc.dg/pr89525.c: New test. + PR c/89520 * gcc.dg/pr89520-1.c: New test. * gcc.dg/pr89520-2.c: New test. diff --git a/gcc/testsuite/gcc.dg/pr89525.c b/gcc/testsuite/gcc.dg/pr89525.c new file mode 100644 index 0000000..099e174 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr89525.c @@ -0,0 +1,11 @@ +/* PR c/89525 */ +/* { dg-do compile } */ +/* { dg-options "-w" } */ + +double sqrt (); /* { dg-bogus "declared here" } */ + +void +foo (void) +{ + sqrt (); +} |