diff options
| author | Richard Biener <rguenther@suse.de> | 2020-03-12 14:18:35 +0100 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2020-03-12 14:19:36 +0100 |
| commit | 1dc00a8ec9aeba86b74b16bff6f171824bb7b4a1 (patch) | |
| tree | eadb3fa8164c3ad87d25d9a15f97b463e138cef6 /gcc | |
| parent | fcc443b97e19d9c8a2d8ccdfa4cc20682165827e (diff) | |
| download | gcc-1dc00a8ec9aeba86b74b16bff6f171824bb7b4a1.zip gcc-1dc00a8ec9aeba86b74b16bff6f171824bb7b4a1.tar.gz gcc-1dc00a8ec9aeba86b74b16bff6f171824bb7b4a1.tar.bz2 | |
tree-optimization/94103 avoid CSE of loads with padding
VN currently replaces a load of a 16 byte entity 128 bits of precision
(TImode) with the result of a load of a 16 byte entity with 80 bits of
mode precision (XFmode). That will go downhill since if the padding
bits are not actually filled with memory contents those bits are
missing.
2020-03-12 Richard Biener <rguenther@suse.de>
PR tree-optimization/94103
* tree-ssa-sccvn.c (visit_reference_op_load): Avoid type
punning when the mode precision is not sufficient.
* gcc.target/i386/pr94103.c: New testcase.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/i386/pr94103.c | 17 | ||||
| -rw-r--r-- | gcc/tree-ssa-sccvn.c | 23 |
4 files changed, 44 insertions, 7 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 22ba5ed..a43b453 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2020-03-12 Richard Biener <rguenther@suse.de> + + PR tree-optimization/94103 + * tree-ssa-sccvn.c (visit_reference_op_load): Avoid type + punning when the mode precision is not sufficient. + 2020-03-12 H.J. Lu <hongjiu.lu@intel.com> PR target/89229 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a1f0e3a..a5730eb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-03-12 Richard Biener <rguenther@suse.de> + + PR tree-optimization/94103 + * gcc.target/i386/pr94103.c: New testcase. + 2020-03-12 Tobias Burnus <tobias@codesourcery.com> PR middle-end/94120 diff --git a/gcc/testsuite/gcc.target/i386/pr94103.c b/gcc/testsuite/gcc.target/i386/pr94103.c new file mode 100644 index 0000000..91b5fc6 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr94103.c @@ -0,0 +1,17 @@ +/* { dg-do run { target lp64 } } */ +/* { dg-options "-O3" } */ + +int main() +{ + long double x; + unsigned long u[2] = {0xEEEEEEEEEEEEEEEEUL, 0xEEEEEEEEEEEEEEEEUL}; + __builtin_memcpy(&x, &u, sizeof x); + __builtin_memcpy(&u, &x, sizeof u); + ++*(unsigned char *)&x; + (void)-x; + __builtin_memcpy(&u, &x, sizeof u); + if (u[1] != 0xEEEEEEEEEEEEEEEEUL + || u[0] != 0xEEEEEEEEEEEEEEEFUL) + __builtin_abort (); + return 0; +} diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c index b7174cd..150ddad 100644 --- a/gcc/tree-ssa-sccvn.c +++ b/gcc/tree-ssa-sccvn.c @@ -4899,13 +4899,22 @@ visit_reference_op_load (tree lhs, tree op, gimple *stmt) if (result && !useless_type_conversion_p (TREE_TYPE (result), TREE_TYPE (op))) { - /* We will be setting the value number of lhs to the value number - of VIEW_CONVERT_EXPR <TREE_TYPE (result)> (result). - So first simplify and lookup this expression to see if it - is already available. */ - gimple_match_op res_op (gimple_match_cond::UNCOND, - VIEW_CONVERT_EXPR, TREE_TYPE (op), result); - result = vn_nary_build_or_lookup (&res_op); + /* Avoid the type punning in case the result mode has padding where + the op we lookup has not. */ + if (maybe_lt (GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (result))), + GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (op))))) + result = NULL_TREE; + else + { + /* We will be setting the value number of lhs to the value number + of VIEW_CONVERT_EXPR <TREE_TYPE (result)> (result). + So first simplify and lookup this expression to see if it + is already available. */ + gimple_match_op res_op (gimple_match_cond::UNCOND, + VIEW_CONVERT_EXPR, TREE_TYPE (op), result); + result = vn_nary_build_or_lookup (&res_op); + } + /* When building the conversion fails avoid inserting the reference again. */ if (!result) |