diff options
author | Andrew MacLeod <amacleod@redhat.com> | 2023-06-10 16:35:18 -0400 |
---|---|---|
committer | Andrew MacLeod <amacleod@redhat.com> | 2023-06-12 10:48:42 -0400 |
commit | 110c1f8d3070919b26646b87e13b9737ff88d606 (patch) | |
tree | dba5349814c309c7ab99bc2401ac622293e8d3ac /gcc | |
parent | 73cbf402d3df24317ae299f52256ddfa93cca402 (diff) | |
download | gcc-110c1f8d3070919b26646b87e13b9737ff88d606.zip gcc-110c1f8d3070919b26646b87e13b9737ff88d606.tar.gz gcc-110c1f8d3070919b26646b87e13b9737ff88d606.tar.bz2 |
Add a hybrid MAX_EXPR operator for integer and pointer.
This adds an operator to the unified table for MAX_EXPR which will
select either the pointer or integer version based on the type passed
to the method. This is for use until we have a seperate PRANGE class.
THIs also removes the pointer table which is no longer needed.
* range-op-mixed.h (operator_max): Remove final.
* range-op-ptr.cc (pointer_table::pointer_table): Remove MAX_EXPR.
(pointer_table::pointer_table): Remove.
(class hybrid_max_operator): New.
(range_op_table::initialize_pointer_ops): Add hybrid_max_operator.
* range-op.cc (pointer_tree_table): Remove.
(unified_table::unified_table): Comment out MAX_EXPR.
(get_op_handler): Remove check of pointer table.
* range-op.h (class pointer_table): Remove.
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/range-op-mixed.h | 6 | ||||
-rw-r--r-- | gcc/range-op-ptr.cc | 30 | ||||
-rw-r--r-- | gcc/range-op.cc | 10 | ||||
-rw-r--r-- | gcc/range-op.h | 9 |
4 files changed, 25 insertions, 30 deletions
diff --git a/gcc/range-op-mixed.h b/gcc/range-op-mixed.h index a659354..bdc488b 100644 --- a/gcc/range-op-mixed.h +++ b/gcc/range-op-mixed.h @@ -636,10 +636,10 @@ class operator_max : public range_operator { public: void update_bitmask (irange &r, const irange &lh, - const irange &rh) const final override; -private: + const irange &rh) const override; +protected: void wi_fold (irange &r, tree type, const wide_int &lh_lb, const wide_int &lh_ub, const wide_int &rh_lb, - const wide_int &rh_ub) const final override; + const wide_int &rh_ub) const override; }; #endif // GCC_RANGE_OP_MIXED_H diff --git a/gcc/range-op-ptr.cc b/gcc/range-op-ptr.cc index 483e43c..ea66fe9 100644 --- a/gcc/range-op-ptr.cc +++ b/gcc/range-op-ptr.cc @@ -157,7 +157,6 @@ pointer_min_max_operator::wi_fold (irange &r, tree type, r.set_varying (type); } - class pointer_and_operator : public range_operator { public: @@ -265,14 +264,6 @@ operator_pointer_diff::op1_op2_relation_effect (irange &lhs_range, tree type, rel); } -// When PRANGE is implemented, these are all the opcodes which are currently -// expecting routines with PRANGE signatures. - -pointer_table::pointer_table () -{ - set (MAX_EXPR, op_ptr_min_max); -} - // ---------------------------------------------------------------------- // Hybrid operators for the 4 operations which integer and pointers share, // but which have different implementations. Simply check the type in @@ -404,8 +395,26 @@ public: } } op_hybrid_min; +class hybrid_max_operator : public operator_max +{ +public: + void update_bitmask (irange &r, const irange &lh, + const irange &rh) const final override + { + if (!r.undefined_p () && INTEGRAL_TYPE_P (r.type ())) + operator_max::update_bitmask (r, lh, rh); + } - + void wi_fold (irange &r, tree type, const wide_int &lh_lb, + const wide_int &lh_ub, const wide_int &rh_lb, + const wide_int &rh_ub) const final override + { + if (INTEGRAL_TYPE_P (type)) + return operator_max::wi_fold (r, type, lh_lb, lh_ub, rh_lb, rh_ub); + else + return op_ptr_min_max.wi_fold (r, type, lh_lb, lh_ub, rh_lb, rh_ub); + } +} op_hybrid_max; // Initialize any pointer operators to the primary table @@ -417,4 +426,5 @@ range_op_table::initialize_pointer_ops () set (BIT_AND_EXPR, op_hybrid_and); set (BIT_IOR_EXPR, op_hybrid_or); set (MIN_EXPR, op_hybrid_min); + set (MAX_EXPR, op_hybrid_max); } diff --git a/gcc/range-op.cc b/gcc/range-op.cc index 481f3b1..046b769 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -49,8 +49,6 @@ along with GCC; see the file COPYING3. If not see #include "tree-ssa-ccp.h" #include "range-op-mixed.h" -pointer_table pointer_tree_table; - // Instantiate a range_op_table for unified operations. class unified_table : public range_op_table { @@ -124,18 +122,14 @@ unified_table::unified_table () // set (BIT_AND_EXPR, op_bitwise_and); // set (BIT_IOR_EXPR, op_bitwise_or); // set (MIN_EXPR, op_min); - set (MAX_EXPR, op_max); + // set (MAX_EXPR, op_max); } // The tables are hidden and accessed via a simple extern function. range_operator * -get_op_handler (enum tree_code code, tree type) +get_op_handler (enum tree_code code, tree) { - // If this is pointer type and there is pointer specifc routine, use it. - if (POINTER_TYPE_P (type) && pointer_tree_table[code]) - return pointer_tree_table[code]; - return unified_tree_table[code]; } diff --git a/gcc/range-op.h b/gcc/range-op.h index 08c51ba..15c4513 100644 --- a/gcc/range-op.h +++ b/gcc/range-op.h @@ -299,15 +299,6 @@ range_op_table::set (enum tree_code code, range_operator &op) m_range_tree[code] = &op; } -// Instantiate a range op table for pointer operations. - -class pointer_table : public range_op_table -{ -public: - pointer_table (); -}; -extern pointer_table pointer_tree_table; - extern range_operator *ptr_op_widen_mult_signed; extern range_operator *ptr_op_widen_mult_unsigned; extern range_operator *ptr_op_widen_plus_signed; |