diff options
| author | Nick Clifton <nickc@cygnus.com> | 1998-09-23 16:24:09 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@gcc.gnu.org> | 1998-09-23 16:24:09 +0000 |
| commit | f916eeb6db92d698c87706411143f50ddfe9b126 (patch) | |
| tree | 330130ec1e4383070201734f7f8622105b6eb795 /gcc | |
| parent | 80db34d85bec3c9378bfeeb7bd5793cb2e35c043 (diff) | |
| download | gcc-f916eeb6db92d698c87706411143f50ddfe9b126.zip gcc-f916eeb6db92d698c87706411143f50ddfe9b126.tar.gz gcc-f916eeb6db92d698c87706411143f50ddfe9b126.tar.bz2 | |
Add comment provided by Jim Wilson.
From-SVN: r22560
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/expmed.c | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c022fc6..8351c37 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +Wed Sep 23 16:22:01 1998 Nick Clifton <nickc@cygnus.com> + + * expmed.c (extract_bit_field): Add comment from Jim Wilson. + Wed Sep 23 13:26:02 1998 Richard Henderson <rth@cygnus.com> * alpha.c (get_aligned_mem): Revert Sep 20 change. diff --git a/gcc/expmed.c b/gcc/expmed.c index 730d904..734365f 100644 --- a/gcc/expmed.c +++ b/gcc/expmed.c @@ -983,6 +983,10 @@ extract_bit_field (str_rtx, bitsize, bitnum, unsignedp, && ((bitsize >= BITS_PER_WORD && bitsize == GET_MODE_BITSIZE (mode) && bitpos % BITS_PER_WORD == 0) || (mode_for_size (bitsize, GET_MODE_CLASS (tmode), 0) != BLKmode + /* ??? The big endian test here is wrong. This is correct + if the value is in a register, and if mode_for_size is not + the same mode as op0. This causes us to get unnecessarily + inefficient code from the Thumb port when -mbig-endian. */ && (BYTES_BIG_ENDIAN ? bitpos + bitsize == BITS_PER_WORD : bitpos == 0)))) |