diff options
| author | Andreas Krebbel <krebbel@linux.ibm.com> | 2019-07-01 14:56:41 +0000 |
|---|---|---|
| committer | Andreas Krebbel <krebbel@gcc.gnu.org> | 2019-07-01 14:56:41 +0000 |
| commit | cbce506fc4c8fe2762f193a51f5bc302e4ae36da (patch) | |
| tree | da39c6b9e330ca549d77df3569a8a487725c423e /gcc | |
| parent | d21c7dd6a2cf854da4776082cc6903acbdf8391f (diff) | |
| download | gcc-cbce506fc4c8fe2762f193a51f5bc302e4ae36da.zip gcc-cbce506fc4c8fe2762f193a51f5bc302e4ae36da.tar.gz gcc-cbce506fc4c8fe2762f193a51f5bc302e4ae36da.tar.bz2 | |
S/390: Fix vector shift count operand
We currently use subst definitions to handle the different variants of shift
count operands. Unfortunately, in the vector shift pattern the shift count
operand is used directly. Without it being adjusted for the 'subst' variants the
displacement value is omitted resulting in a wrong shift count being applied.
This patch needs to be applied to older branches as well.
gcc/ChangeLog:
2019-07-01 Andreas Krebbel <krebbel@linux.ibm.com>
* config/s390/vector.md:
gcc/testsuite/ChangeLog:
2019-07-01 Andreas Krebbel <krebbel@linux.ibm.com>
* gcc.target/s390/vector/vec-shift-2.c: New test.
From-SVN: r272884
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/config/s390/vector.md | 2 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/s390/vector/vec-shift-2.c | 24 |
4 files changed, 33 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 489caf1..990bce2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2019-07-01 Andreas Krebbel <krebbel@linux.ibm.com> + + * config/s390/vector.md: + 2019-07-01 Richard Sandiford <richard.sandiford@arm.com> * ira-lives.c (process_bb_node_lives): Use ira_setup_alts. diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md index a2c1012..140ef47 100644 --- a/gcc/config/s390/vector.md +++ b/gcc/config/s390/vector.md @@ -981,7 +981,7 @@ (VEC_SHIFTS:VI (match_operand:VI 1 "register_operand" "v") (match_operand:SI 2 "nonmemory_operand" "an")))] "TARGET_VX" - "<vec_shifts_mnem><bhfgq>\t%v0,%v1,%Y2" + "<vec_shifts_mnem><bhfgq>\t%v0,%v1,<addr_style_op_ops>" [(set_attr "op_type" "VRS")]) ; Shift each element by corresponding vector element diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 8936a8e..9d9569d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-07-01 Andreas Krebbel <krebbel@linux.ibm.com> + + * gcc.target/s390/vector/vec-shift-2.c: New test. + 2019-07-01 Ed Schonberg <schonberg@adacore.com> * gnat.dg/generic_inst3.adb, diff --git a/gcc/testsuite/gcc.target/s390/vector/vec-shift-2.c b/gcc/testsuite/gcc.target/s390/vector/vec-shift-2.c new file mode 100644 index 0000000..c7a1d93 --- /dev/null +++ b/gcc/testsuite/gcc.target/s390/vector/vec-shift-2.c @@ -0,0 +1,24 @@ +/* { dg-do run } */ +/* { dg-options "-O3 -mzarch -march=z13 --save-temps" } */ + +/* { dg-final { scan-assembler-times "veslf" 1 } } */ + +typedef __attribute__((vector_size(16))) signed int v4si; + +v4si __attribute__((noinline,noclone)) +shift_left_by_scalar (v4si in, int shift_count) +{ + return in << (3 + shift_count); +} + +int +main () +{ + v4si a = { 1, 2, 3, 4 }; + v4si result = shift_left_by_scalar (a, 1); + + if (result[1] != 32) + __builtin_abort (); + + return 0; +} |