diff options
author | Paolo Carlini <paolo.carlini@oracle.com> | 2012-10-15 19:13:41 +0000 |
---|---|---|
committer | Paolo Carlini <paolo@gcc.gnu.org> | 2012-10-15 19:13:41 +0000 |
commit | c9e3b2097b6cd7bd26fad8d5cf3ddd7335776a84 (patch) | |
tree | 2554b65829608295857311aa6a0f6c9aa8133161 /gcc | |
parent | e30440106a536e3d9bf5a1366538d40c7c9fb581 (diff) | |
download | gcc-c9e3b2097b6cd7bd26fad8d5cf3ddd7335776a84.zip gcc-c9e3b2097b6cd7bd26fad8d5cf3ddd7335776a84.tar.gz gcc-c9e3b2097b6cd7bd26fad8d5cf3ddd7335776a84.tar.bz2 |
PR c++/50080 (again)
/cp
2012-10-15 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/50080 (again)
* parser.c (cp_parser_optional_template_keyword): When -pedantic
and C++98 mode restore pre-Core/468 behavior.
/testsuite
2012-10-15 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/50080 (again)
* g++.dg/parse/tmpl-outside2.C: Tweak, error in C++98.
* g++.dg/parse/tmpl-outside1.C: Likewise.
* g++.dg/template/qualttp18.C: Likewise.
* g++.old-deja/g++.pt/memtemp87.C: Likewise.
* g++.old-deja/g++.pt/overload13.C: Likewise.
From-SVN: r192470
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/cp/ChangeLog | 6 | ||||
-rw-r--r-- | gcc/cp/parser.c | 26 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 9 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/parse/tmpl-outside1.C | 2 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/parse/tmpl-outside2.C | 2 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/template/qualttp18.C | 2 | ||||
-rw-r--r-- | gcc/testsuite/g++.old-deja/g++.pt/memtemp87.C | 2 | ||||
-rw-r--r-- | gcc/testsuite/g++.old-deja/g++.pt/overload13.C | 2 |
8 files changed, 43 insertions, 8 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 5239e7e..555345f 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,5 +1,11 @@ 2012-10-15 Paolo Carlini <paolo.carlini@oracle.com> + PR c++/50080 (again) + * parser.c (cp_parser_optional_template_keyword): When -pedantic + and C++98 mode restore pre-Core/468 behavior. + +2012-10-15 Paolo Carlini <paolo.carlini@oracle.com> + PR c++/50080 * parser.c (cp_parser_optional_template_keyword): Implement Core/468, allow outside template. diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 965bc62..853d789 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -23252,9 +23252,29 @@ cp_parser_optional_template_keyword (cp_parser *parser) { if (cp_lexer_next_token_is_keyword (parser->lexer, RID_TEMPLATE)) { - /* Consume the `template' keyword. */ - cp_lexer_consume_token (parser->lexer); - return true; + /* In C++98 the `template' keyword can only be used within templates; + outside templates the parser can always figure out what is a + template and what is not. In C++11, per the resolution of DR 468, + `template' is allowed in cases where it is not strictly necessary. */ + if (!processing_template_decl + && pedantic && cxx_dialect == cxx98) + { + cp_token *token = cp_lexer_peek_token (parser->lexer); + pedwarn (token->location, OPT_Wpedantic, + "in C++98 %<template%> (as a disambiguator) is only " + "allowed within templates"); + /* If this part of the token stream is rescanned, the same + error message would be generated. So, we purge the token + from the stream. */ + cp_lexer_purge_token (parser->lexer); + return false; + } + else + { + /* Consume the `template' keyword. */ + cp_lexer_consume_token (parser->lexer); + return true; + } } return false; } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ea4a46f..99c7a706 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,12 @@ +2012-10-15 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/50080 (again) + * g++.dg/parse/tmpl-outside2.C: Tweak, error in C++98. + * g++.dg/parse/tmpl-outside1.C: Likewise. + * g++.dg/template/qualttp18.C: Likewise. + * g++.old-deja/g++.pt/memtemp87.C: Likewise. + * g++.old-deja/g++.pt/overload13.C: Likewise. + 2012-10-15 Uros Bizjak <ubizjak@gmail.com> * gcc.target/i386/avx256-unaligned-load-1.c: Update asm scan patterns. diff --git a/gcc/testsuite/g++.dg/parse/tmpl-outside1.C b/gcc/testsuite/g++.dg/parse/tmpl-outside1.C index 0713f17..7d969e4 100644 --- a/gcc/testsuite/g++.dg/parse/tmpl-outside1.C +++ b/gcc/testsuite/g++.dg/parse/tmpl-outside1.C @@ -7,4 +7,4 @@ struct X template <int i> struct Y {}; }; -typedef X::template Y<0> y; +typedef X::template Y<0> y; // { dg-error "template|invalid" "" { target c++98 } } diff --git a/gcc/testsuite/g++.dg/parse/tmpl-outside2.C b/gcc/testsuite/g++.dg/parse/tmpl-outside2.C index d35656f..54d39fa 100644 --- a/gcc/testsuite/g++.dg/parse/tmpl-outside2.C +++ b/gcc/testsuite/g++.dg/parse/tmpl-outside2.C @@ -15,5 +15,5 @@ void test() int main() { - typename A<double>::template B<int> b; + typename A<double>::template B<int> b; // { dg-error "template|expected" "" { target c++98 } } } diff --git a/gcc/testsuite/g++.dg/template/qualttp18.C b/gcc/testsuite/g++.dg/template/qualttp18.C index b4d28da..691517f 100644 --- a/gcc/testsuite/g++.dg/template/qualttp18.C +++ b/gcc/testsuite/g++.dg/template/qualttp18.C @@ -14,7 +14,7 @@ template <template <class> class TT> struct X struct C { - X<A::template B> x; + X<A::template B> x; // { dg-error "template" "" { target c++98 } } }; int main() diff --git a/gcc/testsuite/g++.old-deja/g++.pt/memtemp87.C b/gcc/testsuite/g++.old-deja/g++.pt/memtemp87.C index 2554518..51a66fd 100644 --- a/gcc/testsuite/g++.old-deja/g++.pt/memtemp87.C +++ b/gcc/testsuite/g++.old-deja/g++.pt/memtemp87.C @@ -12,4 +12,4 @@ public: template<template<class> class> class Y { }; -Q::template X<int> x; +Q::template X<int> x; // { dg-error "template" "" { target c++98 } } diff --git a/gcc/testsuite/g++.old-deja/g++.pt/overload13.C b/gcc/testsuite/g++.old-deja/g++.pt/overload13.C index 78a5e6d..9c98514 100644 --- a/gcc/testsuite/g++.old-deja/g++.pt/overload13.C +++ b/gcc/testsuite/g++.old-deja/g++.pt/overload13.C @@ -7,5 +7,5 @@ struct A { int main () { A a; - return a.template f (0); + return a.template f (0); // { dg-error "template" "" { target c++98 } } } |