diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2017-12-06 23:48:39 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2017-12-06 23:48:39 +0100 |
| commit | 91c95da87e9a4944f145f988ecbc0926bf68e452 (patch) | |
| tree | 383e77ebc3159ea0e6c80956b6c19fd652bd4791 /gcc | |
| parent | c25ac92773ac357a9dfb831ded2e071f04ec7735 (diff) | |
| download | gcc-91c95da87e9a4944f145f988ecbc0926bf68e452.zip gcc-91c95da87e9a4944f145f988ecbc0926bf68e452.tar.gz gcc-91c95da87e9a4944f145f988ecbc0926bf68e452.tar.bz2 | |
re PR c++/80259 (ICE deleting friend function)
PR c++/80259
* decl2.c (grokfield): Diagnose = delete redefinition of a friend.
* g++.dg/cpp0x/pr80259.C: New test.
From-SVN: r255456
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/cp/decl2.c | 15 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/cpp0x/pr80259.C | 13 |
4 files changed, 35 insertions, 3 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index d8702e3..9bfc72c 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2017-12-06 Jakub Jelinek <jakub@redhat.com> + + PR c++/80259 + * decl2.c (grokfield): Diagnose = delete redefinition of a friend. + 2017-12-06 Jason Merrill <jason@redhat.com> * call.c (convert_for_arg_passing): Pass NULL_TREE to diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index 13e7b1d..2de36fa 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -911,9 +911,18 @@ grokfield (const cp_declarator *declarator, { if (init == ridpointers[(int)RID_DELETE]) { - DECL_DELETED_FN (value) = 1; - DECL_DECLARED_INLINE_P (value) = 1; - DECL_INITIAL (value) = error_mark_node; + if (friendp && decl_defined_p (value)) + { + error ("redefinition of %q#D", value); + inform (DECL_SOURCE_LOCATION (value), + "%q#D previously defined here", value); + } + else + { + DECL_DELETED_FN (value) = 1; + DECL_DECLARED_INLINE_P (value) = 1; + DECL_INITIAL (value) = error_mark_node; + } } else if (init == ridpointers[(int)RID_DEFAULT]) { diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 176777e..d7196733 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-12-06 Jakub Jelinek <jakub@redhat.com> + + PR c++/80259 + * g++.dg/cpp0x/pr80259.C: New test. + 2017-12-06 David Malcolm <dmalcolm@redhat.com> PR c/83236 diff --git a/gcc/testsuite/g++.dg/cpp0x/pr80259.C b/gcc/testsuite/g++.dg/cpp0x/pr80259.C new file mode 100644 index 0000000..9d2a109 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/pr80259.C @@ -0,0 +1,13 @@ +// PR c++/80259 +// { dg-do compile { target c++11 } } + +void foo () {} // { dg-message "previously defined here" } +void bar (); + +struct A +{ + friend void foo () = delete; // { dg-error "redefinition of" } + friend void bar () = delete; // { dg-message "previously defined here" } +}; + +void bar () {} // { dg-error "redefinition of" } |