diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2020-01-29 09:41:42 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2020-01-29 09:41:42 +0100 |
| commit | 8d7c0bf876fa784101f9ad9e3bba82cc065357da (patch) | |
| tree | 98bb52b241add2c6cb1bf9354473a48199d9a236 /gcc | |
| parent | aa1b56967d85bfc80d71341395f862ec2b30ca36 (diff) | |
| download | gcc-8d7c0bf876fa784101f9ad9e3bba82cc065357da.zip gcc-8d7c0bf876fa784101f9ad9e3bba82cc065357da.tar.gz gcc-8d7c0bf876fa784101f9ad9e3bba82cc065357da.tar.bz2 | |
openmp: c++: Consider typeinfo decls to be predetermined shared [PR91118]
If the typeinfo decls appear in OpenMP default(none) regions, as we no longer
predetermine const with no mutable members, they are diagnosed as errors,
but it isn't something the users can actually provide explicit sharing for in
the clauses.
2020-01-29 Jakub Jelinek <jakub@redhat.com>
PR c++/91118
* cp-gimplify.c (cxx_omp_predetermined_sharing): Return
OMP_CLAUSE_DEFAULT_SHARED for typeinfo decls.
* g++.dg/gomp/pr91118-1.C: New test.
* g++.dg/gomp/pr91118-2.C: New test.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/cp/cp-gimplify.c | 4 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/gomp/pr91118-1.C | 12 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/gomp/pr91118-2.C | 14 |
5 files changed, 40 insertions, 0 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 9392c85..4dcdb04 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2020-01-29 Jakub Jelinek <jakub@redhat.com> + + PR c++/91118 + * cp-gimplify.c (cxx_omp_predetermined_sharing): Return + OMP_CLAUSE_DEFAULT_SHARED for typeinfo decls. + 2020-01-28 Jason Merrill <jason@redhat.com> PR c++/93442 diff --git a/gcc/cp/cp-gimplify.c b/gcc/cp/cp-gimplify.c index f3aeb74..4fb3a1a 100644 --- a/gcc/cp/cp-gimplify.c +++ b/gcc/cp/cp-gimplify.c @@ -2187,6 +2187,10 @@ cxx_omp_predetermined_sharing (tree decl) && DECL_OMP_PRIVATIZED_MEMBER (decl))) return OMP_CLAUSE_DEFAULT_SHARED; + /* Similarly for typeinfo symbols. */ + if (VAR_P (decl) && DECL_ARTIFICIAL (decl) && DECL_TINFO_P (decl)) + return OMP_CLAUSE_DEFAULT_SHARED; + return OMP_CLAUSE_DEFAULT_UNSPECIFIED; } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index d13de9a..01aaaf5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2020-01-29 Jakub Jelinek <jakub@redhat.com> + PR c++/91118 + * g++.dg/gomp/pr91118-1.C: New test. + * g++.dg/gomp/pr91118-2.C: New test. + PR fortran/93463 * gfortran.dg/goacc/pr93463.f90: New test. diff --git a/gcc/testsuite/g++.dg/gomp/pr91118-1.C b/gcc/testsuite/g++.dg/gomp/pr91118-1.C new file mode 100644 index 0000000..f29d69d --- /dev/null +++ b/gcc/testsuite/g++.dg/gomp/pr91118-1.C @@ -0,0 +1,12 @@ +// PR c++/91118 +// { dg-do compile } +// { dg-additional-options "-fsanitize=undefined" } + +#include <iostream> + +void +foo () +{ +#pragma omp parallel default(none) shared(std::cerr) + std::cerr << "hello" << std::endl; +} diff --git a/gcc/testsuite/g++.dg/gomp/pr91118-2.C b/gcc/testsuite/g++.dg/gomp/pr91118-2.C new file mode 100644 index 0000000..80f1e3e --- /dev/null +++ b/gcc/testsuite/g++.dg/gomp/pr91118-2.C @@ -0,0 +1,14 @@ +// PR c++/91118 +// { dg-do compile } + +#include <typeinfo> + +struct S { virtual ~S (); }; +void bar (const std::type_info &, const std::type_info &); + +void +foo (S *p) +{ + #pragma omp parallel default (none) firstprivate (p) + bar (typeid (*p), typeid (S)); +} |