diff options
| author | Paolo Carlini <paolo.carlini@oracle.com> | 2018-02-01 15:36:04 +0000 |
|---|---|---|
| committer | Paolo Carlini <paolo@gcc.gnu.org> | 2018-02-01 15:36:04 +0000 |
| commit | 73b7d28f677d9bf4a4ab5ef1f69cf8282a28e377 (patch) | |
| tree | 08eaaa23e6345a60a44473b0b17f23ac9ad82e5b /gcc | |
| parent | 3ae129323d150621d216fbbcdeebf033ef82416f (diff) | |
| download | gcc-73b7d28f677d9bf4a4ab5ef1f69cf8282a28e377.zip gcc-73b7d28f677d9bf4a4ab5ef1f69cf8282a28e377.tar.gz gcc-73b7d28f677d9bf4a4ab5ef1f69cf8282a28e377.tar.bz2 | |
re PR c++/83796 (Abstract classes allowed to be instantiated when initialised as default parameter to function or constructor)
/cp
2018-02-01 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/83796
* call.c (convert_like_real): If w're initializing from {} explicitly
call abstract_virtuals_error_sfinae.
/testsuite
2018-02-01 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/83796
* g++.dg/cpp0x/abstract-default1.C: New.
From-SVN: r257298
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/cp/call.c | 2 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/cpp0x/abstract-default1.C | 26 |
4 files changed, 39 insertions, 0 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 6eb7f27..8fc9042 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2018-02-01 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/83796 + * call.c (convert_like_real): If w're initializing from {} explicitly + call abstract_virtuals_error_sfinae. + 2018-01-31 Jason Merrill <jason@redhat.com> Jakub Jelinek <jakub@redhat.com> diff --git a/gcc/cp/call.c b/gcc/cp/call.c index 46d5ef5..15b723a 100644 --- a/gcc/cp/call.c +++ b/gcc/cp/call.c @@ -6765,6 +6765,8 @@ convert_like_real (conversion *convs, tree expr, tree fn, int argnum, && TYPE_HAS_DEFAULT_CONSTRUCTOR (totype)) { bool direct = CONSTRUCTOR_IS_DIRECT_INIT (expr); + if (abstract_virtuals_error_sfinae (NULL_TREE, totype, complain)) + return error_mark_node; expr = build_value_init (totype, complain); expr = get_target_expr_sfinae (expr, complain); if (expr != error_mark_node) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 3f2f447..465ae15 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-02-01 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/83796 + * g++.dg/cpp0x/abstract-default1.C: New. + 2018-02-01 Richard Sandiford <richard.sandiford@linaro.org> PR tree-optimization/81635 diff --git a/gcc/testsuite/g++.dg/cpp0x/abstract-default1.C b/gcc/testsuite/g++.dg/cpp0x/abstract-default1.C new file mode 100644 index 0000000..e98af76 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/abstract-default1.C @@ -0,0 +1,26 @@ +// PR c++/83796 +// { dg-do compile { target c++11 } } + +struct MyAbstractClass +{ + virtual int foo() const = 0; +}; + +struct TestClass +{ + TestClass(const MyAbstractClass& m = {}) // { dg-error "abstract type" } + : value_(m.foo()) {} + + int value_; +}; + +int TestFunction(const MyAbstractClass& m = {}) // { dg-error "abstract type" } +{ + return m.foo(); +} + +int main() +{ + TestClass testInstance; // { dg-error "abstract type" } + TestFunction(); // { dg-error "abstract type" } +} |