diff options
| author | Richard Guenther <rguenther@suse.de> | 2010-04-30 08:22:15 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2010-04-30 08:22:15 +0000 |
| commit | 4be68d9a2d50985d79835f109a46d7665eec721a (patch) | |
| tree | 44218b6855bc66127f9b11af7c5a184ffc5ce829 /gcc | |
| parent | 0646825443aef1495f97f719f91fdc7a5c1e26f8 (diff) | |
| download | gcc-4be68d9a2d50985d79835f109a46d7665eec721a.zip gcc-4be68d9a2d50985d79835f109a46d7665eec721a.tar.gz gcc-4be68d9a2d50985d79835f109a46d7665eec721a.tar.bz2 | |
re PR tree-optimization/43879 (-fipa-pta causes various miscompilations)
2010-04-30 Richard Guenther <rguenther@suse.de>
PR tree-optimization/43879
* tree-ssa-structalias.c (get_constraint_for_1): Properly
handle non-zero initializers.
* gcc.dg/torture/pr43879_1.c: New testcase.
From-SVN: r158924
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/torture/pr43879_1.c | 27 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/torture/pr43879_2.c | 17 | ||||
| -rw-r--r-- | gcc/tree-ssa-structalias.c | 6 |
5 files changed, 59 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index d20e202..936a8386 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,11 @@ 2010-04-30 Richard Guenther <rguenther@suse.de> + PR tree-optimization/43879 + * tree-ssa-structalias.c (get_constraint_for_1): Properly + handle non-zero initializers. + +2010-04-30 Richard Guenther <rguenther@suse.de> + * builtins.c (fold_builtin_1): Delete free (0). 2010-04-29 Jan HUbicka <jh@suse.cz> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index cf678b8..f3284dc 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2010-04-30 Richard Guenther <rguenther@suse.de> + PR tree-optimization/43879 + * gcc.dg/torture/pr43879_1.c: New testcase. + +2010-04-30 Richard Guenther <rguenther@suse.de> + * gcc.dg/tree-ssa/builtin-free.c: New testcase. 2010-04-29 Fabien Chêne <fabien.chene@gmail.com> diff --git a/gcc/testsuite/gcc.dg/torture/pr43879_1.c b/gcc/testsuite/gcc.dg/torture/pr43879_1.c new file mode 100644 index 0000000..151a184 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr43879_1.c @@ -0,0 +1,27 @@ +/* { dg-do run } */ +/* { dg-options "-fipa-pta" } */ +/* { dg-additional-sources "pr43879_2.c" } */ + +void bar(int c) +{ + static int x = 1; + if (c != x) __builtin_abort(); + x--; +} + +void baz(int *i) +{ + (*i)--; +} + +struct TBL { + int (*p)(int *i); +}; +extern struct TBL tbl; + +int main() +{ + int c = 1; + return tbl.p(&c); +} + diff --git a/gcc/testsuite/gcc.dg/torture/pr43879_2.c b/gcc/testsuite/gcc.dg/torture/pr43879_2.c new file mode 100644 index 0000000..8155653 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr43879_2.c @@ -0,0 +1,17 @@ +struct TBL { + int (*p)(int *i); +}; + +extern void bar(int i); +extern void baz(int *i); + +static int foo(int *i) +{ + bar(*i); + baz(i); + bar(*i); + return *i; +} + +struct TBL tbl = { foo }; + diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c index 08d3fa7..928dc04 100644 --- a/gcc/tree-ssa-structalias.c +++ b/gcc/tree-ssa-structalias.c @@ -3285,8 +3285,10 @@ get_constraint_for_1 (tree t, VEC (ce_s, heap) **results, bool address_p) && ((TREE_CODE (t) == INTEGER_CST && integer_zerop (t)) /* The only valid CONSTRUCTORs in gimple with pointer typed - elements are zero-initializer. */ - || TREE_CODE (t) == CONSTRUCTOR)) + elements are zero-initializer. But in IPA mode we also + process global initializers, so verify at least. */ + || (TREE_CODE (t) == CONSTRUCTOR + && CONSTRUCTOR_NELTS (t) == 0))) { temp.var = nothing_id; temp.type = ADDRESSOF; |