aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorTom de Vries <tom@codesourcery.com>2018-03-26 09:45:49 +0000
committerTom de Vries <vries@gcc.gnu.org>2018-03-26 09:45:49 +0000
commit46dbeb4085e4a5492579d06641d0aae25b80b465 (patch)
tree2e2968f8a5a77268b1d31ec7e2c78a3ac5a6014f /gcc
parentc2f3aac4541abf92c5a3554f77c58dcb5e68413d (diff)
downloadgcc-46dbeb4085e4a5492579d06641d0aae25b80b465.zip
gcc-46dbeb4085e4a5492579d06641d0aae25b80b465.tar.gz
gcc-46dbeb4085e4a5492579d06641d0aae25b80b465.tar.bz2
Fix switch conversion in offloading functions
2018-03-26 Tom de Vries <tom@codesourcery.com> PR tree-optimization/85063 * omp-general.c (offloading_function_p): New function. Factor out of ... * omp-offload.c (pass_omp_target_link::gate): ... here. * omp-general.h (offloading_function_p): Declare. * tree-switch-conversion.c (build_one_array): Mark CSWTCH.x variable with attribute omp declare target for offloading functions. * testsuite/libgomp.c/switch-conversion-2.c: New test. * testsuite/libgomp.c/switch-conversion.c: New test. * testsuite/libgomp.oacc-c-c++-common/switch-conversion-2.c: New test. * testsuite/libgomp.oacc-c-c++-common/switch-conversion.c: New test. From-SVN: r258852
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ChangeLog10
-rw-r--r--gcc/omp-general.c10
-rw-r--r--gcc/omp-general.h1
-rw-r--r--gcc/omp-offload.c4
-rw-r--r--gcc/tree-switch-conversion.c5
5 files changed, 27 insertions, 3 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 9526547..a8d9e76 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,13 @@
+2018-03-26 Tom de Vries <tom@codesourcery.com>
+
+ PR tree-optimization/85063
+ * omp-general.c (offloading_function_p): New function. Factor out
+ of ...
+ * omp-offload.c (pass_omp_target_link::gate): ... here.
+ * omp-general.h (offloading_function_p): Declare.
+ * tree-switch-conversion.c (build_one_array): Mark CSWTCH.x variable
+ with attribute omp declare target for offloading functions.
+
2018-03-24 Richard Sandiford <richard.sandiford@linaro.org>
PR tree-optimization/84005
diff --git a/gcc/omp-general.c b/gcc/omp-general.c
index 3ef6ce7..cabbbbc 100644
--- a/gcc/omp-general.c
+++ b/gcc/omp-general.c
@@ -612,6 +612,16 @@ oacc_get_fn_attrib (tree fn)
return lookup_attribute (OACC_FN_ATTRIB, DECL_ATTRIBUTES (fn));
}
+/* Return true if FN is an OpenMP or OpenACC offloading function. */
+
+bool
+offloading_function_p (tree fn)
+{
+ tree attrs = DECL_ATTRIBUTES (fn);
+ return (lookup_attribute ("omp declare target", attrs)
+ || lookup_attribute ("omp target entrypoint", attrs));
+}
+
/* Extract an oacc execution dimension from FN. FN must be an
offloaded function or routine that has already had its execution
dimensions lowered to the target-specific values. */
diff --git a/gcc/omp-general.h b/gcc/omp-general.h
index 481a885..66f0a33 100644
--- a/gcc/omp-general.h
+++ b/gcc/omp-general.h
@@ -85,6 +85,7 @@ extern void oacc_replace_fn_attrib (tree fn, tree dims);
extern void oacc_set_fn_attrib (tree fn, tree clauses, vec<tree> *args);
extern tree oacc_build_routine_dims (tree clauses);
extern tree oacc_get_fn_attrib (tree fn);
+extern bool offloading_function_p (tree fn);
extern int oacc_get_fn_dim_size (tree fn, int axis);
extern int oacc_get_ifn_dim_arg (const gimple *stmt);
diff --git a/gcc/omp-offload.c b/gcc/omp-offload.c
index 9cbc51d..0abf028 100644
--- a/gcc/omp-offload.c
+++ b/gcc/omp-offload.c
@@ -1967,9 +1967,7 @@ public:
virtual bool gate (function *fun)
{
#ifdef ACCEL_COMPILER
- tree attrs = DECL_ATTRIBUTES (fun->decl);
- return lookup_attribute ("omp declare target", attrs)
- || lookup_attribute ("omp target entrypoint", attrs);
+ return offloading_function_p (fun->decl);
#else
(void) fun;
return false;
diff --git a/gcc/tree-switch-conversion.c b/gcc/tree-switch-conversion.c
index 2da7068..b0470ef 100644
--- a/gcc/tree-switch-conversion.c
+++ b/gcc/tree-switch-conversion.c
@@ -49,6 +49,7 @@ Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
#include "alloc-pool.h"
#include "target.h"
#include "tree-into-ssa.h"
+#include "omp-general.h"
/* ??? For lang_hooks.types.type_for_mode, but is there a word_mode
type in the GIMPLE type system that is language-independent? */
@@ -1162,6 +1163,10 @@ build_one_array (gswitch *swtch, int num, tree arr_index_type,
TREE_CONSTANT (decl) = 1;
TREE_READONLY (decl) = 1;
DECL_IGNORED_P (decl) = 1;
+ if (offloading_function_p (cfun->decl))
+ DECL_ATTRIBUTES (decl)
+ = tree_cons (get_identifier ("omp declare target"), NULL_TREE,
+ NULL_TREE);
varpool_node::finalize_decl (decl);
fetch = build4 (ARRAY_REF, value_type, decl, tidx, NULL_TREE,