diff options
| author | Jan Hubicka <hubicka@freesoft.cz> | 1999-09-22 03:40:28 +0200 |
|---|---|---|
| committer | Richard Henderson <rth@gcc.gnu.org> | 1999-09-21 18:40:28 -0700 |
| commit | 00ec6daa3ca775bae5983d6df8d3085726f6c4b0 (patch) | |
| tree | 69498a5fa35f9d9f80f26b15296fb08ae527ef19 /gcc | |
| parent | 35cc13e4b6f2ba0dd80cfbd650c643bc86b9ba48 (diff) | |
| download | gcc-00ec6daa3ca775bae5983d6df8d3085726f6c4b0.zip gcc-00ec6daa3ca775bae5983d6df8d3085726f6c4b0.tar.gz gcc-00ec6daa3ca775bae5983d6df8d3085726f6c4b0.tar.bz2 | |
Jan Hubicka <hubicka@freesoft.cz>
* genrecog.c (not_both_true): Handle correctly cases when called for
tests with different positions in the insn.
From-SVN: r29573
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/genrecog.c | 38 |
2 files changed, 43 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 614f1f9..93f0ee5 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +Tue Sep 21 18:40:01 1999 Jan Hubicka <hubicka@freesoft.cz> + + * genrecog.c (not_both_true): Handle correctly cases when called for + tests with different positions in the insn. + Tue Sep 21 18:29:11 1999 Kaveh R. Ghazi <ghazi@caip.rutgers.edu> * machmode.h (HOST_PTR_PRINTF): Move from here ... diff --git a/gcc/genrecog.c b/gcc/genrecog.c index 4d3d749..d63c8cf 100644 --- a/gcc/genrecog.c +++ b/gcc/genrecog.c @@ -685,6 +685,44 @@ not_both_true (d1, d2, toplevel) int toplevel; { struct decision *p1, *p2; + int cmp; + + /* Don't compare strings on the different positions in insn. Doing so + is incorrect and results in false matches from constructs like + + [(set (subreg:HI (match_operand:SI "register_operand" "r") 0) + (subreg:HI (match_operand:SI "register_operand" "r") 0))] + vs + [(set (match_operand:HI "register_operand" "r") + (match_operand:HI "register_operand" "r"))] + + If we are presented with such, we are recursing through the remainder + of a node's success nodes (from the loop at the end of this function). + Skip forward until we come to a position that matches. + + Due to the way position strings are constructed, we know that iterating + forward from the lexically lower position (e.g. "00") will run into + the lexically higher position (e.g. "1") and not the other way around. + This saves a bit of effort. */ + + cmp = strcmp (d1->position, d2->position); + if (cmp != 0) + { + if (toplevel) + abort(); + + /* If the d2->position was lexically lower, swap. */ + if (cmp > 0) + p1 = d1; d1 = d2; d2 = p1; + + if (d1->success.first == 0) + return 0; + for (p1 = d1->success.first; p1; p1 = p1->next) + if (! not_both_true (p1, d2, 0)) + return 0; + + return 1; + } /* If they are both to test modes and the modes are different, they aren't both true. Similarly for codes, integer elements, and vector lengths. */ |