diff options
| author | Jan Hubicka <hubicka@ucw.cz> | 2014-08-02 17:13:41 +0200 |
|---|---|---|
| committer | Jan Hubicka <hubicka@gcc.gnu.org> | 2014-08-02 15:13:41 +0000 |
| commit | 91bc34a94d157c64f82477e8cd44d55494e7b1b7 (patch) | |
| tree | 363affad7849abba7c8f191cdaf2dbd6f8c056a5 /gcc/varpool.c | |
| parent | b787e7a2c2c9be2f548d4c76ec324b71859851a4 (diff) | |
| download | gcc-91bc34a94d157c64f82477e8cd44d55494e7b1b7.zip gcc-91bc34a94d157c64f82477e8cd44d55494e7b1b7.tar.gz gcc-91bc34a94d157c64f82477e8cd44d55494e7b1b7.tar.bz2 | |
invoke.texi (Wsuggest-final-types, [...]): Document.
* doc/invoke.texi (Wsuggest-final-types, Wsuggest-final-methods): Document.
* ipa-devirt.c: Include hash-map.h
(struct polymorphic_call_target_d): Add type_warning and decl_warning.
(clear_speculation): Break out of ...
(get_class_context): ... here; speed up handling obviously useless
speculations.
(odr_type_warn_count, decl_warn_count): New structures.
(final_warning_record): New structure.
(final_warning_records): New static variable.
(possible_polymorphic_call_targets): Cleanup handling of speculative info;
do not build speculation when user do not care; record info about warnings
when asked for.
(add_decl_warning): New function.
(type_warning_cmp): New function.
(decl_warning_cmp): New function.
(ipa_devirt): Handle -Wsuggest-final-methods and -Wsuggest-final-types.
(gate): Enable pass when warnings are requested.
* common.opt (Wsuggest-final-types, Wsuggest-final-methods): New options.
* g++.dg/warn/Wsuggest-final.C: New testcase.
* g++.dg/ipa/devirt-34.C: Fix.
From-SVN: r213518
Diffstat (limited to 'gcc/varpool.c')
| -rw-r--r-- | gcc/varpool.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/gcc/varpool.c b/gcc/varpool.c index 41b83d7..8350adb 100644 --- a/gcc/varpool.c +++ b/gcc/varpool.c @@ -340,8 +340,16 @@ varpool_node::ctor_useable_for_folding_p (void) /* Variables declared 'const' without an initializer have zero as the initializer if they may not be - overridden at link or run time. */ - if (!DECL_INITIAL (real_node->decl) + overridden at link or run time. + + It is actually requirement for C++ compiler to optimize const variables + consistently. As a GNU extension, do not enfore this rule for user defined + weak variables, so we support interposition on: + static const int dummy = 0; + extern const int foo __attribute__((__weak__, __alias__("dummy"))); + */ + if ((!DECL_INITIAL (real_node->decl) + || (DECL_WEAK (decl) && !DECL_COMDAT (decl))) && (DECL_EXTERNAL (decl) || decl_replaceable_p (decl))) return false; |