diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2013-06-12 08:43:05 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2013-06-12 08:43:05 +0200 |
| commit | 946f9306f214a4e4e3c41f02aa3cc814e04d022d (patch) | |
| tree | c806eb7d0ba1820a5a6649401babc1d807a5a876 /gcc/varasm.c | |
| parent | a7fca6f045a40bb74cbb90993d8befbbee4e29f6 (diff) | |
| download | gcc-946f9306f214a4e4e3c41f02aa3cc814e04d022d.zip gcc-946f9306f214a4e4e3c41f02aa3cc814e04d022d.tar.gz gcc-946f9306f214a4e4e3c41f02aa3cc814e04d022d.tar.bz2 | |
re PR target/56564 (movdqa on possibly-8-byte-aligned struct with -O3)
PR target/56564
* varasm.c (decl_binds_to_current_def_p): Call binds_local_p
target hook even for !TREE_PUBLIC decls. If no resolution info
is available, return false for common and external decls.
From-SVN: r199984
Diffstat (limited to 'gcc/varasm.c')
| -rw-r--r-- | gcc/varasm.c | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/gcc/varasm.c b/gcc/varasm.c index d2b9415..d817067 100644 --- a/gcc/varasm.c +++ b/gcc/varasm.c @@ -6781,10 +6781,10 @@ bool decl_binds_to_current_def_p (tree decl) { gcc_assert (DECL_P (decl)); - if (!TREE_PUBLIC (decl)) - return true; if (!targetm.binds_local_p (decl)) return false; + if (!TREE_PUBLIC (decl)) + return true; /* When resolution is available, just use it. */ if (TREE_CODE (decl) == VAR_DECL && (TREE_STATIC (decl) || DECL_EXTERNAL (decl))) @@ -6802,10 +6802,20 @@ decl_binds_to_current_def_p (tree decl) return resolution_to_local_definition_p (node->symbol.resolution); } /* Otherwise we have to assume the worst for DECL_WEAK (hidden weaks - binds locally but still can be overwritten). + binds locally but still can be overwritten), DECL_COMMON (can be merged + with a non-common definition somewhere in the same module) or + DECL_EXTERNAL. This rely on fact that binds_local_p behave as decl_replaceable_p for all other declaration types. */ - return !DECL_WEAK (decl); + if (DECL_WEAK (decl)) + return false; + if (DECL_COMMON (decl) + && (DECL_INITIAL (decl) == NULL + || DECL_INITIAL (decl) == error_mark_node)) + return false; + if (DECL_EXTERNAL (decl)) + return false; + return true; } /* A replaceable function or variable is one which may be replaced |