diff options
author | Jakub Jelinek <jakub@redhat.com> | 2022-09-17 08:18:24 +0200 |
---|---|---|
committer | Jakub Jelinek <jakub@redhat.com> | 2022-09-17 08:18:24 +0200 |
commit | 9ac9fde961f76879f0379ff3b2494a2f9ac915f7 (patch) | |
tree | 7acab99b000e17f41620f94f5b35156643a340fe /gcc/value-range.h | |
parent | 7ee0fa100f0f28d7b88237d520131e07b7b49f0a (diff) | |
download | gcc-9ac9fde961f76879f0379ff3b2494a2f9ac915f7.zip gcc-9ac9fde961f76879f0379ff3b2494a2f9ac915f7.tar.gz gcc-9ac9fde961f76879f0379ff3b2494a2f9ac915f7.tar.bz2 |
reassoc: Fix up recent regression in optimize_range_tests_cmp_bitwise [PR106958]
As the following testcase reduced from glibc fmtmsg.c shows
(it doesn't ICE on x86_64/i686 unfortunately, but does on various other
arches), my last optimize_range_tests_cmp_bitwise change wasn't fully
correct. The intent was to let all pointer operands be cast to
pointer_sized_int_node first in addition to the other casts (to type1)
which are done for id >= l cases.
But one spot I've touched used always cast to type1 (note, the (b % 4) == 3
case is impossible for pointer operands because that is for !TYPE_UNSIGNED
operands and pointers are TYPE_UNSIGNED) and in the other spot the cast
would be done only for id >= l if not useless, but for pointers we need
to cast it always.
2022-09-17 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/106958
* tree-ssa-reassoc.cc (optimize_range_tests_cmp_bitwise): If
id >= l, cast op to type1, otherwise to pointer_sized_int_node.
If type has pointer type, cast exp to pointer_sized_int_node
even when id < l.
* gcc.c-torture/compile/pr106958.c: New test.
Diffstat (limited to 'gcc/value-range.h')
0 files changed, 0 insertions, 0 deletions