diff options
author | Martin Sebor <msebor@redhat.com> | 2020-12-01 15:10:30 -0700 |
---|---|---|
committer | Martin Sebor <msebor@redhat.com> | 2020-12-01 15:11:23 -0700 |
commit | b76f83e3859f738809d3aa8bd9dc14e10fc40e24 (patch) | |
tree | cea67a727e59839591dffa2a523f0e4552f2eea3 /gcc/tree.c | |
parent | c7e2ef13149791be24bc563428fcb864e770d843 (diff) | |
download | gcc-b76f83e3859f738809d3aa8bd9dc14e10fc40e24.zip gcc-b76f83e3859f738809d3aa8bd9dc14e10fc40e24.tar.gz gcc-b76f83e3859f738809d3aa8bd9dc14e10fc40e24.tar.bz2 |
PR middle-end/97595 - bogus -Wstringop-overflow due to DECL_SIZE_UNIT underreporting field size
gcc/ChangeLog:
PR middle-end/97595
* tree.c (component_ref_size): Fail when DECL_SIZE != TYPE_SIZE.
* tree.h (DECL_SIZE, TYPE_SIZE): Update comment.
gcc/testsuite/ChangeLog:
PR middle-end/97595
* g++.dg/warn/Warray-bounds-14.C: New test.
* g++.dg/warn/Wstringop-overflow-6.C: New test.
Diffstat (limited to 'gcc/tree.c')
-rw-r--r-- | gcc/tree.c | 12 |
1 files changed, 9 insertions, 3 deletions
@@ -13740,9 +13740,9 @@ component_ref_size (tree ref, special_array_member *sam /* = NULL */) { gcc_assert (TREE_CODE (ref) == COMPONENT_REF); - special_array_member arkbuf; + special_array_member sambuf; if (!sam) - sam = &arkbuf; + sam = &sambuf; *sam = special_array_member::none; /* The object/argument referenced by the COMPONENT_REF and its type. */ @@ -13756,7 +13756,13 @@ component_ref_size (tree ref, special_array_member *sam /* = NULL */) { tree memtype = TREE_TYPE (member); if (TREE_CODE (memtype) != ARRAY_TYPE) - return memsize; + /* DECL_SIZE may be less than TYPE_SIZE in C++ when referring + to the type of a class with a virtual base which doesn't + reflect the size of the virtual's members (see pr97595). + If that's the case fail for now and implement something + more robust in the future. */ + return (tree_int_cst_equal (memsize, TYPE_SIZE_UNIT (memtype)) + ? memsize : NULL_TREE); bool trailing = array_at_struct_end_p (ref); bool zero_length = integer_zerop (memsize); |