diff options
author | Jason Merrill <jason@redhat.com> | 2019-04-29 13:27:13 -0400 |
---|---|---|
committer | Jason Merrill <jason@gcc.gnu.org> | 2019-04-29 13:27:13 -0400 |
commit | d407e7f53b4a9c3f607b692d89b4ad7d87df5933 (patch) | |
tree | 3c9963eb4dd5887df09070c5d7199822d305c7d4 /gcc/tree-tailcall.c | |
parent | 348dd384c8f647ba56be21932d068d180be243e3 (diff) | |
download | gcc-d407e7f53b4a9c3f607b692d89b4ad7d87df5933.zip gcc-d407e7f53b4a9c3f607b692d89b4ad7d87df5933.tar.gz gcc-d407e7f53b4a9c3f607b692d89b4ad7d87df5933.tar.bz2 |
PR c++/82081 - tail call optimization breaks noexcept
If a noexcept function calls a function that might throw, doing the tail
call optimization means that an exception thrown in the called function
will propagate out, breaking the noexcept specification. So we need to
prevent the optimization in that case.
* tree-tailcall.c (find_tail_calls): Don't turn a call from a
nothrow function to a might-throw function into a tail call.
From-SVN: r270656
Diffstat (limited to 'gcc/tree-tailcall.c')
-rw-r--r-- | gcc/tree-tailcall.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gcc/tree-tailcall.c b/gcc/tree-tailcall.c index afe8931..e0265b2 100644 --- a/gcc/tree-tailcall.c +++ b/gcc/tree-tailcall.c @@ -37,6 +37,7 @@ along with GCC; see the file COPYING3. If not see #include "tree-into-ssa.h" #include "tree-dfa.h" #include "except.h" +#include "tree-eh.h" #include "dbgcnt.h" #include "cfgloop.h" #include "common/common-target.h" @@ -472,6 +473,12 @@ find_tail_calls (basic_block bb, struct tailcall **ret) && !auto_var_in_fn_p (ass_var, cfun->decl)) return; + /* If the call might throw an exception that wouldn't propagate out of + cfun, we can't transform to a tail or sibling call (82081). */ + if (stmt_could_throw_p (cfun, stmt) + && !stmt_can_throw_external (cfun, stmt)) + return; + /* We found the call, check whether it is suitable. */ tail_recursion = false; func = gimple_call_fndecl (call); |