Remove unnecessary VEC function overloads.

Several VEC member functions that accept an element 'T' used to have
two overloads: one taking 'T', the second taking 'T *'.

This used to be needed because of the interface dichotomy between
vectors of objects and vectors of pointers.  In the past, vectors of
pointers would use pass-by-value semantics, but vectors of objects
would use pass-by-reference semantics.  This is no longer necessary,
but the distinction had remained.

The main side-effect of this change is some code reduction in code
that manipulates vectors of objects.  For instance,

-  struct iterator_use *iuse;
-
-  iuse = VEC_safe_push (iterator_use, heap, iterator_uses, NULL);
-  iuse->iterator = iterator;
-  iuse->ptr = ptr;
+  struct iterator_use iuse = {iterator, ptr};
+  VEC_safe_push (iterator_use, heap, iterator_uses, iuse);

Compile time performance was not affected.

Tested on x86_64 and ppc64.

Also built all-gcc on all targets using VEC routines: arm, bfin, c6x,
epiphany, ia64, mips, sh, spu, and vms.

2012-09-10  Diego Novillo  <dnovillo@google.com>

	* vec.h (vec_t::quick_push): Remove overload that accepts 'T *'.
	Update all users.
	(vec_t::safe_push): Likewise.
	(vec_t::quick_insert): Likewise.
	(vec_t::lower_bound): Likewise.
	(vec_t::safe_insert): Likewise.
	(vec_t::replace): Change second argument to 'T &'.

From-SVN: r191165

1 files changed, 8 insertions, 11 deletions

diff --git a/gcc/tree-switch-conversion.c b/gcc/tree-switch-conversion.c
index bb89d30..bbbd3ca 100644
--- a/gcc/tree-switch-conversion.c
+++ b/gcc/tree-switch-conversion.c
@@ -868,13 +868,11 @@ build_constructors (gimple swtch, struct switch_conv_info *info)
 	  int k;
 	  for (k = 0; k < info->phi_count; k++)
 	    {
-	      constructor_elt *elt;
+	      constructor_elt elt;
 
-	      elt = VEC_quick_push (constructor_elt,
-				    info->constructors[k], NULL);
-	      elt->index = int_const_binop (MINUS_EXPR, pos,
-					    info->range_min);
-	      elt->value = info->default_values[k];
+	      elt.index = int_const_binop (MINUS_EXPR, pos, info->range_min);
+	      elt.value = info->default_values[k];
+	      VEC_quick_push (constructor_elt, info->constructors[k], elt);
 	    }
 
 	  pos = int_const_binop (PLUS_EXPR, pos, integer_one_node);
@@ -896,12 +894,11 @@ build_constructors (gimple swtch, struct switch_conv_info *info)
 
 	  do
 	    {
-	      constructor_elt *elt;
+	      constructor_elt elt;
 
-	      elt = VEC_quick_push (constructor_elt,
-				    info->constructors[j], NULL);
-	      elt->index = int_const_binop (MINUS_EXPR, pos, info->range_min);
-	      elt->value = val;
+	      elt.index = int_const_binop (MINUS_EXPR, pos, info->range_min);
+	      elt.value = val;
+	      VEC_quick_push (constructor_elt, info->constructors[j], elt);
 
 	      pos = int_const_binop (PLUS_EXPR, pos, integer_one_node);
 	    } while (!tree_int_cst_lt (high, pos)