diff options
| author | Richard Biener <rguenther@suse.de> | 2016-09-27 12:56:38 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2016-09-27 12:56:38 +0000 |
| commit | 59896334f97c1d58c221d2975e33abccd0d331d5 (patch) | |
| tree | 98081d1a890b16cf38fe47a5ae0e7aa4b27bb30d /gcc/tree-ssa-pre.c | |
| parent | 4e7e89e8c9acdbffa6546d5e6056c7b81238c88f (diff) | |
| download | gcc-59896334f97c1d58c221d2975e33abccd0d331d5.zip gcc-59896334f97c1d58c221d2975e33abccd0d331d5.tar.gz gcc-59896334f97c1d58c221d2975e33abccd0d331d5.tar.bz2 | |
re PR tree-optimization/77745 (Inconsistent application of aliasing rules)
2016-09-27 Richard Biener <rguenther@suse.de>
PR tree-optimization/77745
* tree-ssa-pre.c (eliminate_dom_walker::before_dom_children):
When removing redundant stores make sure to check compatibility
of the TBAA state for downstream accesses.
* tree-ssa-sccvn.c (visit_reference_op_store): Likewise for when
value-numbering virtual operands for store matches.
* g++.dg/torture/pr77745.C: New testcase.
From-SVN: r240534
Diffstat (limited to 'gcc/tree-ssa-pre.c')
| -rw-r--r-- | gcc/tree-ssa-pre.c | 44 |
1 files changed, 26 insertions, 18 deletions
diff --git a/gcc/tree-ssa-pre.c b/gcc/tree-ssa-pre.c index 0c6f820..3675fb9 100644 --- a/gcc/tree-ssa-pre.c +++ b/gcc/tree-ssa-pre.c @@ -4431,26 +4431,34 @@ eliminate_dom_walker::before_dom_children (basic_block b) && !is_gimple_reg (gimple_assign_lhs (stmt)) && (TREE_CODE (gimple_assign_rhs1 (stmt)) == SSA_NAME || is_gimple_min_invariant (gimple_assign_rhs1 (stmt)))) - { - tree val; + { + tree val; tree rhs = gimple_assign_rhs1 (stmt); - val = vn_reference_lookup (gimple_assign_lhs (stmt), - gimple_vuse (stmt), VN_WALK, NULL, false); - if (TREE_CODE (rhs) == SSA_NAME) - rhs = VN_INFO (rhs)->valnum; - if (val - && operand_equal_p (val, rhs, 0)) - { - if (dump_file && (dump_flags & TDF_DETAILS)) - { - fprintf (dump_file, "Deleted redundant store "); - print_gimple_stmt (dump_file, stmt, 0, 0); - } + vn_reference_t vnresult; + val = vn_reference_lookup (lhs, gimple_vuse (stmt), VN_WALKREWRITE, + &vnresult, false); + if (TREE_CODE (rhs) == SSA_NAME) + rhs = VN_INFO (rhs)->valnum; + if (val + && operand_equal_p (val, rhs, 0)) + { + /* We can only remove the later store if the former aliases + at least all accesses the later one does. */ + alias_set_type set = get_alias_set (lhs); + if (vnresult->set == set + || alias_set_subset_of (set, vnresult->set)) + { + if (dump_file && (dump_flags & TDF_DETAILS)) + { + fprintf (dump_file, "Deleted redundant store "); + print_gimple_stmt (dump_file, stmt, 0, 0); + } - /* Queue stmt for removal. */ - el_to_remove.safe_push (stmt); - continue; - } + /* Queue stmt for removal. */ + el_to_remove.safe_push (stmt); + continue; + } + } } /* If this is a control statement value numbering left edges |