diff options
author | Jonathan Wakely <jwakely@redhat.com> | 2023-07-19 14:42:51 +0100 |
---|---|---|
committer | Jonathan Wakely <jwakely@redhat.com> | 2023-07-19 16:48:56 +0100 |
commit | 344f41322023cdbf4532b5278443a22a4f391627 (patch) | |
tree | 8bfb4d174de52c5021aa0a2fa51af3065be8d7b0 /gcc/tree-ssa-phiopt.cc | |
parent | 86b36e9f7e3839e923db2fda4962cd3faf2ea47b (diff) | |
download | gcc-344f41322023cdbf4532b5278443a22a4f391627.zip gcc-344f41322023cdbf4532b5278443a22a4f391627.tar.gz gcc-344f41322023cdbf4532b5278443a22a4f391627.tar.bz2 |
libstdc++: Fix formatting of negative chrono::hh_mm_ss
When formatting with an empty chrono spec ("{}") two minus signs were
being added to hh_mm_ss values. This is because the __is_neg flag was
checked to add one explicitly, and then the ostream operator added
another one.
We should only check the __is_neg flag for durations, because those are
the only types which are modified to be non-negative before calling
_M_format. We don't change hh_mm_ss values to be negative, because that
would require performing arithmetic on the hh_mm_ss members to sum them,
and then again to construct a new hh_mm_ss object with the positive
value. Instead, we can just be careful about using the __is_neg flag
correctly.
To fix the bug, _M_format_to_ostream no longer checks the __is_neg flag
for non-durations, and _M_format doesn't set it for hh_mm_ss until after
the call to _M_format_to_ostream. We can also avoid setting it for types
that it doesn't apply to, by making the __print_sign lambda only inspect
it for duration and hh_mm_ss types.
libstdc++-v3/ChangeLog:
* include/bits/chrono_io.h (__formatter_chrono::_M_format):
Do not set __is_neg for hh_mm_ss before calling
_M_format_to_ostream. Change __print_sign lambda to only check
__is_neg for durations and hh_mm_ss types.
(__formatter_chrono::_M_format_to_ostream): Only check __is_neg
for duration types.
* testsuite/std/time/hh_mm_ss/io.cc: Check negative values.
Diffstat (limited to 'gcc/tree-ssa-phiopt.cc')
0 files changed, 0 insertions, 0 deletions