diff options
| author | Richard Sandiford <richard.sandiford@linaro.org> | 2017-12-07 18:43:40 +0000 |
|---|---|---|
| committer | Richard Sandiford <rsandifo@gcc.gnu.org> | 2017-12-07 18:43:40 +0000 |
| commit | c348cab062adf3946fdadff884b7f43774d72d8f (patch) | |
| tree | 92bd80b3ea4488a4ef1d0b49290f617f3f264c06 /gcc/testsuite | |
| parent | 63570af0b58a3c354723bc78b75d76dbb0750f47 (diff) | |
| download | gcc-c348cab062adf3946fdadff884b7f43774d72d8f.zip gcc-c348cab062adf3946fdadff884b7f43774d72d8f.tar.gz gcc-c348cab062adf3946fdadff884b7f43774d72d8f.tar.bz2 | |
[AArch64] Fix ICEs in aarch64_print_operand
Three related regression fixes:
- We can't use asserts like:
gcc_assert (GET_MODE_SIZE (mode) == 16);
in aarch64_print_operand because it could trigger for invalid user input.
- The output_operand_lossage in aarch64_print_address_internal:
output_operand_lossage ("invalid operand for '%%%c'", op);
wasn't right because "op" is an rtx_code enum rather than the
prefix character.
- aarch64_print_operand_address shouldn't call output_operand_lossage
(because it doesn't have a prefix code) but instead fall back to
output_addr_const.
2017-12-05 Richard Sandiford <richard.sandiford@linaro.org>
gcc/
* config/aarch64/aarch64.c (aarch64_print_address_internal): Return
a bool success value. Don't call output_operand_lossage here.
(aarch64_print_ldpstp_address): Return a bool success value.
(aarch64_print_operand_address): Call output_addr_const if
aarch64_print_address_internal fails.
(aarch64_print_operand): Don't assert that the mode is 16 bytes for
'y'; call output_operand_lossage instead. Call output_operand_lossage
if aarch64_print_ldpstp_address fails.
gcc/testsuite/
* gcc.target/aarch64/asm-2.c: New test.
* gcc.target/aarch64/asm-3.c: Likewise.
From-SVN: r255481
Diffstat (limited to 'gcc/testsuite')
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/aarch64/asm-2.c | 10 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/aarch64/asm-3.c | 10 |
3 files changed, 25 insertions, 0 deletions
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index fd46db7..3a22f21 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-12-07 Richard Sandiford <richard.sandiford@linaro.org> + + * gcc.target/aarch64/asm-2.c: New test. + * gcc.target/aarch64/asm-3.c: Likewise. + 2017-12-07 Bin Cheng <bin.cheng@arm.com> Richard Biener <rguenther@suse.de> diff --git a/gcc/testsuite/gcc.target/aarch64/asm-2.c b/gcc/testsuite/gcc.target/aarch64/asm-2.c new file mode 100644 index 0000000..3f978f5 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/asm-2.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +int x; + +void +f (void) +{ + asm volatile ("%a0" :: "X" (&x)); +} diff --git a/gcc/testsuite/gcc.target/aarch64/asm-3.c b/gcc/testsuite/gcc.target/aarch64/asm-3.c new file mode 100644 index 0000000..75317bd --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/asm-3.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +int x; + +void +f (void) +{ + asm volatile ("%y0" :: "X" (x)); /* { dg-error "invalid" } */ +} |