diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2023-04-22 20:14:06 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2023-04-22 20:14:06 +0200 |
| commit | 195270d28a534cc1f08478c6e0136f4fc13d247a (patch) | |
| tree | 0c45356cbc8f6f57b34f1f57a9f339f254ae6011 /gcc/system.h | |
| parent | 00c49869fed445bf0f70cfa06b9bae1e75a393c8 (diff) | |
| download | gcc-195270d28a534cc1f08478c6e0136f4fc13d247a.zip gcc-195270d28a534cc1f08478c6e0136f4fc13d247a.tar.gz gcc-195270d28a534cc1f08478c6e0136f4fc13d247a.tar.bz2 | |
Fix up bootstrap with GCC 4.[89] after RAII auto_mpfr and autp_mpz [PR109589]
On Tue, Apr 18, 2023 at 03:39:41PM +0200, Richard Biener via Gcc-patches wrote:
> The following adds two RAII classes, one for mpz_t and one for mpfr_t
> making object lifetime management easier. Both formerly require
> explicit initialization with {mpz,mpfr}_init and release with
> {mpz,mpfr}_clear.
This unfortunately broke bootstrap when using GCC 4.8.x or 4.9.x as
it uses deleted friends which weren't supported until PR62101 fixed
them in 2014 for GCC 5.
The following patch adds an workaround, not deleting those friends
for those old versions.
While it means if people add those mp*_{init{,2},clear} calls on auto_mp*
objects they won't notice when doing non-bootstrap builds using
very old system compilers, people should be bootstrapping their changes
and it will be caught during bootstraps even when starting with those
old compilers, plus most people actually use much newer compilers
when developing.
2023-04-22 Jakub Jelinek <jakub@redhat.com>
PR bootstrap/109589
* system.h (class auto_mpz): Workaround PR62101 bug in GCC 4.8 and 4.9.
* realmpfr.h (class auto_mpfr): Likewise.
Diffstat (limited to 'gcc/system.h')
| -rw-r--r-- | gcc/system.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gcc/system.h b/gcc/system.h index c67bc42..5109c60 100644 --- a/gcc/system.h +++ b/gcc/system.h @@ -714,8 +714,11 @@ public: auto_mpz (const auto_mpz &) = delete; auto_mpz &operator= (const auto_mpz &) = delete; +#if GCC_VERSION < 4008 || GCC_VERSION >= 5000 + /* GCC 4.8 and 4.9 don't support this, only fixed in PR62101 for 5.0. */ friend void mpz_clear (auto_mpz&) = delete; friend void mpz_init (auto_mpz&) = delete; +#endif private: mpz_t m_mpz; |