diff options
author | Steven Bosscher <steven@gcc.gnu.org> | 2012-08-18 13:44:00 +0000 |
---|---|---|
committer | Steven Bosscher <steven@gcc.gnu.org> | 2012-08-18 13:44:00 +0000 |
commit | a9c283a506663a1bb97330a609a3c443043424b1 (patch) | |
tree | 980b6b631fae3d1c10abb0b3a6d5cc8cc56d40b1 /gcc/sparseset.c | |
parent | e0de76d8ada17851ca194da894f15f6f61cfd662 (diff) | |
download | gcc-a9c283a506663a1bb97330a609a3c443043424b1.zip gcc-a9c283a506663a1bb97330a609a3c443043424b1.tar.gz gcc-a9c283a506663a1bb97330a609a3c443043424b1.tar.bz2 |
sparseset.c (sparseset_alloc): Use non-clearing allocation.
* sparseset.c (sparseset_alloc): Use non-clearing allocation. Tell
valgrind not to worry about reading from unitialized memory.
From-SVN: r190503
Diffstat (limited to 'gcc/sparseset.c')
-rw-r--r-- | gcc/sparseset.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/gcc/sparseset.c b/gcc/sparseset.c index 823919a..35a2c3e 100644 --- a/gcc/sparseset.c +++ b/gcc/sparseset.c @@ -30,12 +30,14 @@ sparseset_alloc (SPARSESET_ELT_TYPE n_elms) unsigned int n_bytes = sizeof (struct sparseset_def) + ((n_elms - 1) * 2 * sizeof (SPARSESET_ELT_TYPE)); - /* We use xcalloc rather than xmalloc to silence some valgrind uninitialized + sparseset set = XNEWVAR(struct sparseset_def, n_bytes); + + /* Mark the sparseset as defined to silence some valgrind uninitialized read errors when accessing set->sparse[n] when "n" is not, and never has been, in the set. These uninitialized reads are expected, by design and - harmless. If this turns into a performance problem due to some future - additional users of sparseset, we can revisit this decision. */ - sparseset set = (sparseset) xcalloc (1, n_bytes); + harmless. */ + VALGRIND_DISCARD (VALGRIND_MAKE_MEM_DEFINED (set, n_bytes)); + set->dense = &(set->elms[0]); set->sparse = &(set->elms[n_elms]); set->size = n_elms; |