Merge #1174

1174: Remove default location for `SimplePath`s r=CohenArthur a=CohenArthur

This removes the default argument for the locus of `SimplePath`s. Addresses #1159 

There are a lot of places in the code where it is not possible to insert a "correct" location for these `SimplePath`s: namely, when creating the use statement for the standard library's prelude, or when creating the `SimplePath`s of attributes. I've left a few FIXMEs in these cases because I'm unsure about the proper course of action.

Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>

1 files changed, 7 insertions, 4 deletions

diff --git a/gcc/rust/rust-session-manager.cc b/gcc/rust/rust-session-manager.cc
index bdab0d8..8876459 100644
--- a/gcc/rust/rust-session-manager.cc
+++ b/gcc/rust/rust-session-manager.cc
@@ -870,7 +870,8 @@ Session::injection (AST::Crate &crate)
     {
       // create "macro use" attribute for use on extern crate item to enable
       // loading macros from it
-      AST::Attribute attr (AST::SimplePath::from_str ("macro_use"), nullptr);
+      AST::Attribute attr (AST::SimplePath::from_str ("macro_use", Location ()),
+			   nullptr);
 
       // create "extern crate" item with the name
       std::unique_ptr<AST::ExternCrate> extern_crate (
@@ -885,13 +886,15 @@ Session::injection (AST::Crate &crate)
   // create use tree path
   // prelude is injected_crate_name
   std::vector<AST::SimplePathSegment> segments
-    = {AST::SimplePathSegment (injected_crate_name),
-       AST::SimplePathSegment ("prelude"), AST::SimplePathSegment ("v1")};
+    = {AST::SimplePathSegment (injected_crate_name, Location ()),
+       AST::SimplePathSegment ("prelude", Location ()),
+       AST::SimplePathSegment ("v1", Location ())};
   // create use tree and decl
   std::unique_ptr<AST::UseTreeGlob> use_tree (
     new AST::UseTreeGlob (AST::UseTreeGlob::PATH_PREFIXED,
 			  AST::SimplePath (std::move (segments)), Location ()));
-  AST::Attribute prelude_attr (AST::SimplePath::from_str ("prelude_import"),
+  AST::Attribute prelude_attr (AST::SimplePath::from_str ("prelude_import",
+							  Location ()),
 			       nullptr);
   std::unique_ptr<AST::UseDeclaration> use_decl (
     new AST::UseDeclaration (std::move (use_tree),