Fix name resolution using self paths and nested functions

When we resolve paths the code was looking at the crate hierarchy first
in the algorithm this leads to a bug where in rust you can have a function
named foo at the item level then declare a nested function with the same
name. So when we wanted to call the nested function the code was defaulting
to the toplevel first resulting in bad name resolution.

This patch updates the code to look at the scope first, then look at the
module scope hierarchy. It finally adds the error handling in a nice single
path at the end. We can only error out if its not the first segment since
paths such as associated types like Self::foo we cannot resolve foo as this
requires the type-resolution system to determine the projection.

Fixes #1231

0 files changed, 0 insertions, 0 deletions