aboutsummaryrefslogtreecommitdiff
path: root/gcc/rust/lex
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2022-07-19 11:51:22 +0000
committerGitHub <noreply@github.com>2022-07-19 11:51:22 +0000
commit137cd3bbaa05038b01c46f7ac7472da7ca662ed7 (patch)
tree9541637ba71200d98109f7bc3f698842deb4848e /gcc/rust/lex
parent1b5676645a52f46de0011b9434f76c249fbb8d81 (diff)
parent66af31d5bc5a1ea76be381dc9246fbe4fe034fbb (diff)
downloadgcc-137cd3bbaa05038b01c46f7ac7472da7ca662ed7.zip
gcc-137cd3bbaa05038b01c46f7ac7472da7ca662ed7.tar.gz
gcc-137cd3bbaa05038b01c46f7ac7472da7ca662ed7.tar.bz2
Merge #1397
1397: lexer: Allow specifiying tokens as reserved in certain editions r=CohenArthur a=CohenArthur Some tokens such as `try` only became reserved keywords in certain editions. This behavior might happen again in the future and we should be able to handle it. Closes #1395 Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>
Diffstat (limited to 'gcc/rust/lex')
-rw-r--r--gcc/rust/lex/rust-lex.cc19
1 files changed, 17 insertions, 2 deletions
diff --git a/gcc/rust/lex/rust-lex.cc b/gcc/rust/lex/rust-lex.cc
index 93d96d3..ecf151d 100644
--- a/gcc/rust/lex/rust-lex.cc
+++ b/gcc/rust/lex/rust-lex.cc
@@ -21,6 +21,7 @@
#include "rust-system.h" // for rust_assert and rust_unreachable
#include "rust-diagnostics.h" // for rust_error_at
#include "rust-linemap.h"
+#include "rust-session-manager.h"
#include "safe-ctype.h"
namespace Rust {
@@ -228,10 +229,24 @@ Lexer::classify_keyword (const std::string &str)
if (idx == last || str != *idx)
return IDENTIFIER;
- else
- return keyword_keys[idx - keyword_index];
// TODO: possibly replace this x-macro system with something like hash map?
+
+ // We now have the expected token ID of the reserved keyword. However, some
+ // keywords are reserved starting in certain editions. For example, `try` is
+ // only a reserved keyword in editions >=2018. The language might gain new
+ // reserved keywords in the future.
+ //
+ // https://doc.rust-lang.org/reference/keywords.html#reserved-keywords
+ auto id = keyword_keys[idx - keyword_index];
+
+ // `try` is not a reserved keyword before 2018
+ if (Session::get_instance ().options.get_edition ()
+ == CompileOptions::Edition::E2015
+ && id == TRY)
+ return IDENTIFIER;
+
+ return id;
}
TokenPtr