diff options
| author | Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com> | 2023-09-01 13:14:09 +0200 |
|---|---|---|
| committer | CohenArthur <arthur.cohen@embecosm.com> | 2023-09-07 14:08:53 +0000 |
| commit | b6284bd9ff6f54136e6a88c261546a2b6ff12572 (patch) | |
| tree | 843d3a06c2314e7c165325500c2b001a1e90fee2 /gcc/rust/hir/rust-hir-dump.cc | |
| parent | e1d0b3cc02826bf6f2224434c6a1c46c0bb03d0b (diff) | |
| download | gcc-b6284bd9ff6f54136e6a88c261546a2b6ff12572.zip gcc-b6284bd9ff6f54136e6a88c261546a2b6ff12572.tar.gz gcc-b6284bd9ff6f54136e6a88c261546a2b6ff12572.tar.bz2 | |
Unify raw attribute values
Attribute values were used as raw string, this is error prone and
makes renaming harder. Using a constexpr instead will leverage the power
of the compiler and emit an error when an incorrect builtin attribute
value is used.
gcc/rust/ChangeLog:
* ast/rust-ast.cc (Attribute::check_cfg_predicate): Change raw
string to constexpr call.
(Attribute::separate_cfg_attrs): Likewise.
* backend/rust-compile-base.cc (should_mangle_item): Likewise.
(HIRCompileBase::setup_fndecl): Likewise.
(HIRCompileBase::handle_cold_attribute_on_fndecl): Likewise.
* checks/errors/privacy/rust-privacy-reporter.cc (find_proc_macro_attribute):
Likewise.
* checks/errors/rust-unsafe-checker.cc (check_target_attr):
Likewise.
* expand/rust-cfg-strip.cc (fails_cfg): Likewise.
(fails_cfg_with_expand): Likewise.
(expand_cfg_attrs): Likewise.
* expand/rust-macro-builtins.cc: Likewise.
* hir/rust-ast-lower-base.cc (ASTLoweringBase::handle_outer_attributes): Likewise.
(ASTLoweringBase::lower_macro_definition): Likewise.
* hir/rust-hir-dump.cc (Dump::visit): Likewise.
* parse/rust-parse-impl.h (Parser::parse_doc_comment): Likewise.
* parse/rust-parse.cc (extract_module_path): Likewise.
* resolve/rust-early-name-resolver.cc (is_macro_use_module):
Likewise.
(EarlyNameResolver::visit): Likewise.
* resolve/rust-toplevel-name-resolver-2.0.cc (is_macro_export):
Likwise.
* rust-session-manager.cc (Session::injection): Likewise.
* typecheck/rust-hir-type-check-base.cc (TypeCheckBase::parse_repr_options): Likewise.
* util/rust-attributes.cc (is_proc_macro_type): Likewise.
(AttributeChecker::check_attribute): Likewise.
(AttributeChecker::visit): Likewise.
* util/rust-hir-map.cc (Mappings::insert_macro_def): Likewise.
* util/rust-attribute-values.h: New file.
Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Diffstat (limited to 'gcc/rust/hir/rust-hir-dump.cc')
| -rw-r--r-- | gcc/rust/hir/rust-hir-dump.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gcc/rust/hir/rust-hir-dump.cc b/gcc/rust/hir/rust-hir-dump.cc index 5f585b7..973b583 100644 --- a/gcc/rust/hir/rust-hir-dump.cc +++ b/gcc/rust/hir/rust-hir-dump.cc @@ -23,6 +23,7 @@ #include "rust-hir-type.h" #include "rust-hir.h" #include <string> +#include "rust-attribute-values.h" namespace Rust { namespace HIR { @@ -633,7 +634,7 @@ void Dump::visit (AST::Attribute &attribute) { // Special, no begin/end as this is called by do_inner_attrs. - put_field ("path", attribute.get_path ().as_string ()); + put_field (Values::Attributes::PATH, attribute.get_path ().as_string ()); std::string str = "none"; if (attribute.has_attr_input ()) |