aboutsummaryrefslogtreecommitdiff
path: root/gcc/rust/expand/rust-macro-expand.cc
diff options
context:
space:
mode:
authorArthur Cohen <arthur.cohen@embecosm.com>2022-03-21 17:27:05 +0100
committerArthur Cohen <arthur.cohen@embecosm.com>2022-03-22 16:00:30 +0100
commitef5638186202daac03feed7a20eb975991965403 (patch)
tree247ff565c1d06636f05afbd5cd7af555e6d160bb /gcc/rust/expand/rust-macro-expand.cc
parentcc6e405912c83aee41efd3015d9157cdbe9134fe (diff)
downloadgcc-ef5638186202daac03feed7a20eb975991965403.zip
gcc-ef5638186202daac03feed7a20eb975991965403.tar.gz
gcc-ef5638186202daac03feed7a20eb975991965403.tar.bz2
parser: Add better restrictions around semicolons in statements
When parsing macro invocations, rustc does not actually consume the statement's trailing semicolon. Let's take the following example: ```rust macro_rules! one_stmt { ($s:stmt) => {}; } macro_rules! one_or_more_stmt { ($($s:stmt)*) => {}; } one_stmt!(let a = 1); one_stmt!(let b = 2;); // error one_or_more_stmt!(;); // valid one_or_more_stmt!(let a = 15;); // valid, two statements! one_or_more_stmt!(let a = 15 let b = 13); // valid, two statements again ``` A semicolon can count as a valid empty statement, but cannot be part of a statement (in macro invocations). This commit adds more restrictions that allow the parser to not always expect a semicolon token after the statement. Furthermore, this fixes a test that was previously accepted by the compiler but not by rustc.
Diffstat (limited to 'gcc/rust/expand/rust-macro-expand.cc')
-rw-r--r--gcc/rust/expand/rust-macro-expand.cc16
1 files changed, 11 insertions, 5 deletions
diff --git a/gcc/rust/expand/rust-macro-expand.cc b/gcc/rust/expand/rust-macro-expand.cc
index 6b26f98..8294008 100644
--- a/gcc/rust/expand/rust-macro-expand.cc
+++ b/gcc/rust/expand/rust-macro-expand.cc
@@ -477,9 +477,12 @@ MacroExpander::match_fragment (Parser<MacroInvocLexer> &parser,
parser.parse_visibility ();
break;
- case AST::MacroFragSpec::STMT:
- parser.parse_stmt (/* allow_no_semi */ true);
- break;
+ case AST::MacroFragSpec::STMT: {
+ auto restrictions = ParseRestrictions ();
+ restrictions.consume_semi = false;
+ parser.parse_stmt (restrictions);
+ break;
+ }
case AST::MacroFragSpec::LIFETIME:
parser.parse_lifetime_params ();
@@ -887,11 +890,14 @@ transcribe_many_trait_impl_items (Parser<MacroInvocLexer> &parser,
static std::vector<AST::SingleASTNode>
transcribe_many_stmts (Parser<MacroInvocLexer> &parser, TokenId &delimiter)
{
+ auto restrictions = ParseRestrictions ();
+ restrictions.consume_semi = false;
+
// FIXME: This is invalid! It needs to also handle cases where the macro
// transcriber is an expression, but since the macro call is followed by
// a semicolon, it's a valid ExprStmt
- return parse_many (parser, delimiter, [&parser] () {
- auto stmt = parser.parse_stmt (/* allow_no_semi */ true);
+ return parse_many (parser, delimiter, [&parser, restrictions] () {
+ auto stmt = parser.parse_stmt (restrictions);
return AST::SingleASTNode (std::move (stmt));
});
}