diff options
author | Philip Herron <philip.herron@embecosm.com> | 2021-05-14 12:23:33 +0100 |
---|---|---|
committer | Philip Herron <philip.herron@embecosm.com> | 2021-05-14 12:34:24 +0100 |
commit | 9bcbfee5f3e7d69b59c985404b3e4e0788f4a607 (patch) | |
tree | 4ab3ce185bf03a191ad4241fc72a3c957066fa1d /gcc/rust/backend/rust-compile.cc | |
parent | 5d7fbc4a78897f8f561bdd78b4d3bbc15f4b351f (diff) | |
download | gcc-9bcbfee5f3e7d69b59c985404b3e4e0788f4a607.zip gcc-9bcbfee5f3e7d69b59c985404b3e4e0788f4a607.tar.gz gcc-9bcbfee5f3e7d69b59c985404b3e4e0788f4a607.tar.bz2 |
Add FNV-128 hash for legacy symbol mangling
Rustc uses a SIP128 hash for the legacy symbol mangling but an FNV hash is
simpler to implement this is a port of the implementation from golang
stdlib hash package.
The fingerprint for the hash is simple the function signiture for now.
Rustc takes into account options such as -Cmetadata to generate uniqueness.
We still need to implement an SIP128 and the V0 symbol mangling but this
will do in the interim.
Addresses: #305
Fixes: #428
Diffstat (limited to 'gcc/rust/backend/rust-compile.cc')
-rw-r--r-- | gcc/rust/backend/rust-compile.cc | 35 |
1 files changed, 28 insertions, 7 deletions
diff --git a/gcc/rust/backend/rust-compile.cc b/gcc/rust/backend/rust-compile.cc index 9dd3b57..480afc8b 100644 --- a/gcc/rust/backend/rust-compile.cc +++ b/gcc/rust/backend/rust-compile.cc @@ -20,6 +20,7 @@ #include "rust-compile-item.h" #include "rust-compile-expr.h" #include "rust-compile-struct-field-expr.h" +#include "fnv-hash.h" namespace Rust { namespace Compile { @@ -427,10 +428,23 @@ mangle_name (const std::string &name) return std::to_string (name.size ()) + name; } +// rustc uses a sip128 hash for legacy mangling, but an fnv 128 was quicker to +// implement for now static std::string -dummy_hash () +legacy_hash (const std::string &fingerprint) { - return "h0123456789abcdef"; + Hash::FNV128 hasher; + hasher.write ((const unsigned char *) fingerprint.c_str (), + fingerprint.size ()); + + uint64_t hi, lo; + hasher.sum (&hi, &lo); + + char hex[16 + 1]; + memset (hex, 0, sizeof hex); + snprintf (hex, sizeof hex, "%08lx%08lx", lo, hi); + + return "h" + std::string (hex, sizeof (hex) - 1); } static std::string @@ -464,21 +478,28 @@ mangle_self (const TyTy::BaseType *self) } std::string -Context::mangle_item (const std::string &name) const +Context::mangle_item (const TyTy::BaseType *ty, const std::string &name) const { const std::string &crate_name = mappings->get_current_crate_name (); + + const std::string hash = legacy_hash (ty->as_string ()); + const std::string hash_sig = mangle_name (hash); + return kMangledSymbolPrefix + mangle_name (crate_name) + mangle_name (name) - + mangle_name (dummy_hash ()) + kMangledSymbolDelim; + + hash_sig + kMangledSymbolDelim; } std::string -Context::mangle_impl_item (const TyTy::BaseType *self, +Context::mangle_impl_item (const TyTy::BaseType *self, const TyTy::BaseType *ty, const std::string &name) const { const std::string &crate_name = mappings->get_current_crate_name (); + + const std::string hash = legacy_hash (ty->as_string ()); + const std::string hash_sig = mangle_name (hash); + return kMangledSymbolPrefix + mangle_name (crate_name) + mangle_self (self) - + mangle_name (name) + mangle_name (dummy_hash ()) - + kMangledSymbolDelim; + + mangle_name (name) + hash_sig + kMangledSymbolDelim; } } // namespace Compile |